Skip to content

Rename identifiers more idiomatically #413

@toddbaert

Description

@toddbaert

Rename various identifiers to align with language best practices and conventions. For example, ErrProviderFatal instead of ProviderFatalError and ErrProviderNotReady instead of ProviderNotReadyError. There is also a WithTransactionContext function, but there is no TransactionContext type at all. I understand that transaction context is a term defined in the spec, but it is confusing to users. Instead we can document that as a go doc comment. It should be named ContextWithEvaluationContext instead. See the OTel trace package for good names for these types of functions. Similarly, the TransactionContext function should be named EvaluationContextFromContext instead. The convention here is TypeNameFromContext and ContextWithTypeName, where TypeName is the name of the type of identifier being stored/retrieved from the context.

Rename all identifiers/functions to be more Go idiomatic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions