-
Notifications
You must be signed in to change notification settings - Fork 50
Description
[Suggested by @toddbaert] We could consider removing these functions entirely. They return errors directly, which add complexity and is arguably against the spec, which says evaluation methods should never abnormally terminate (returning a non-nil error in Go signals an abnormal termination equivalent to throwing IMO). People actually complained about the ergonomics of these and we implemented the non-error-returning versions in response. The "detailed" evaluation methods also return errors, and we have no "non-error" variant. We should consider our options here to make these consistent and idiomatic.
Consider removing evaluation functions returning errors. This is somewhat against spec, and people complained about the ergonomics long ago, causing us to build the non-error-returning versions.