fix: use-integer-and-default-environment-refresh-interval-to-60

Signed-off-by: wadii <[email protected]>

Author: Zaimwa9

providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithClientConfigurer.java

@@ -118,7 +118,7 @@ private static FlagsmithConfig initializeConfig(FlagsmithProviderOptions options
             flagsmithConfig.withLocalEvaluation(options.isLocalEvaluation());
         }
 
-        if (options.getEnvironmentRefreshIntervalSeconds() > -1) {
+        if (options.getEnvironmentRefreshIntervalSeconds() != null) {
             flagsmithConfig.withEnvironmentRefreshIntervalSeconds(options.getEnvironmentRefreshIntervalSeconds());
         }
 

providers/flagsmith/src/main/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderOptions.java

@@ -118,7 +118,8 @@ public class FlagsmithProviderOptions {
      * Set environment refresh rate with polling manager. Only needed when local evaluation is true.
      * Optional. Default: 60
      */
-    private int environmentRefreshIntervalSeconds = 60;
+    @Builder.Default
+    private Integer environmentRefreshIntervalSeconds = 60;
 
     /**
      * Controls whether Flag Analytics data is sent to the Flagsmith API See

providers/flagsmith/src/test/java/dev.openfeature.contrib.providers.flagsmith/FlagsmithProviderTest.java

@@ -203,6 +203,15 @@ void shouldGetMetadataAndValidateName() {
                         .getName());
     }
 
+    @Test
+    void shouldDefaultEnvironmentRefreshIntervalSecondsTo60() {
+        FlagsmithProviderOptions options = FlagsmithProviderOptions.builder()
+                .apiKey("API_KEY")
+                .localEvaluation(true)
+                .build();
+        assertEquals(Integer.valueOf(60), options.getEnvironmentRefreshIntervalSeconds());
+    }
+
     @ParameterizedTest
     @MethodSource("invalidOptions")
     void shouldThrowAnExceptionWhenOptionsInvalid(FlagsmithProviderOptions options) {