Skip to content

Commit 15e8e10

Browse files
authored
chore: remove STATIC -> DEFAULT mapping (#113)
Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Todd Baert <[email protected]>
1 parent 7c12187 commit 15e8e10

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -160,16 +160,11 @@ public ProviderEvaluation<Value> getObjectEvaluation(String key, Value defaultVa
160160
}
161161

162162
// Map FlagD reasons to Java SDK reasons.
163-
private Reason mapReason(String flagDreason) {
164-
if (!EnumUtils.isValidEnum(Reason.class, flagDreason)) {
165-
// until we have "STATIC" in the spec and SDK, we map STATIC to DEFAULT
166-
if ("STATIC".equals(flagDreason)) {
167-
return Reason.DEFAULT;
168-
} else {
169-
return Reason.UNKNOWN;
170-
}
163+
private Reason mapReason(String flagdReason) {
164+
if (!EnumUtils.isValidEnum(Reason.class, flagdReason)) {
165+
return Reason.UNKNOWN;
171166
} else {
172-
return Reason.valueOf(flagDreason);
167+
return Reason.valueOf(flagdReason);
173168
}
174169
}
175170

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/FlagdProviderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,12 @@ void context_is_parsed_and_passed_to_grpc_service() {
148148
}};
149149
final String STRUCT_ATTR_INNER_VALUE = "struct-inner-value";
150150
final Structure STRUCT_ATTR_VALUE = new Structure().add(STRUCT_ATTR_INNER_KEY, STRUCT_ATTR_INNER_VALUE);
151-
final String STATIC = "STATIC";
151+
final String DEFAULT_STRING = "DEFAULT";
152152

153153
ResolveBooleanResponse booleanResponse = ResolveBooleanResponse.newBuilder()
154154
.setValue(true)
155155
.setVariant(BOOL_VARIANT)
156-
.setReason(STATIC.toString())
156+
.setReason(DEFAULT_STRING.toString())
157157
.build();
158158

159159
ServiceBlockingStub serviceBlockingStubMock = mock(ServiceBlockingStub.class);

0 commit comments

Comments
 (0)