|
16 | 16 | <!-- exclusion expression for e2e tests --> |
17 | 17 | <testExclusions>**/e2e/*.java</testExclusions> |
18 | 18 | <io.grpc.version>1.69.0</io.grpc.version> |
| 19 | + <!-- caution - updating this will break compatibility with older protobuf-java versions --> |
19 | 20 | <protobuf-java.min.version>3.25.5</protobuf-java.min.version> |
20 | 21 | </properties> |
21 | 22 |
|
|
38 | 39 | <dependency> |
39 | 40 | <groupId>com.google.protobuf</groupId> |
40 | 41 | <artifactId>protobuf-java</artifactId> |
41 | | - <!-- 5.0.0-rc < 5.0.0, unfortunately --> |
42 | | - <version>[${protobuf-java.min.version},4.999999)</version> |
43 | 42 | </dependency> |
44 | 43 |
|
45 | 44 | <dependency> |
|
153 | 152 |
|
154 | 153 | </dependencies> |
155 | 154 |
|
| 155 | + <dependencyManagement> |
| 156 | + <dependencies> |
| 157 | + <!-- we need to generate protobuf sources with the minium protobuf version we want to be compatible with --> |
| 158 | + <dependency> |
| 159 | + <groupId>com.google.protobuf</groupId> |
| 160 | + <artifactId>protobuf-java</artifactId> |
| 161 | + <!-- caution - updating this will break compatibility with older protobuf-java versions --> |
| 162 | + <version>${protobuf-java.min.version}</version> |
| 163 | + </dependency> |
| 164 | + </dependencies> |
| 165 | + |
| 166 | + </dependencyManagement> |
| 167 | + |
156 | 168 | <build> |
157 | 169 | <!-- required for protobuf generation --> |
158 | 170 | <extensions> |
|
238 | 250 | </build> |
239 | 251 |
|
240 | 252 | <profiles> |
241 | | - <profile> |
242 | | - <!-- this profile forces us to compile against our minimum version of protobuf-java, |
243 | | - which is required so we can be compatible with both protobuf-java@v3 and protobuf-java@v4 consumers --> |
244 | | - <id>build</id> |
245 | | - <activation> |
246 | | - <activeByDefault>true</activeByDefault> |
247 | | - </activation> |
248 | | - |
249 | | - <dependencies> |
250 | | - <dependency> |
251 | | - <groupId>com.google.protobuf</groupId> |
252 | | - <artifactId>protobuf-java</artifactId> |
253 | | - <!-- must match minimum version in protobuf-java dependency range above --> |
254 | | - <version>${protobuf-java.min.version}</version> |
255 | | - </dependency> |
256 | | - </dependencies> |
257 | | - |
258 | | - </profile> |
259 | 253 | <profile> |
260 | 254 | <!-- this profile handles running the flagd e2e tests --> |
261 | 255 | <id>e2e</id> |
|
0 commit comments