Skip to content

Commit 9fe354f

Browse files
committed
fix(flagd): Add selector back into our requests
Signed-off-by: Simon Schrottner <[email protected]>
1 parent 83fba0c commit 9fe354f

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/connector/grpc/GrpcStreamConnector.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,16 @@ public GrpcStreamConnector(final FlagdOptions options, Consumer<FlagdProviderEve
5151
FlagSyncServiceGrpc::newStub,
5252
FlagSyncServiceGrpc::newBlockingStub,
5353
onConnectionEvent,
54-
stub -> stub.syncFlags(SyncFlagsRequest.getDefaultInstance(), new GrpcStreamHandler(streamReceiver)));
54+
stub -> {
55+
String localSelector = selector;
56+
57+
final SyncFlagsRequest.Builder syncRequest = SyncFlagsRequest.newBuilder();
58+
if (localSelector != null) {
59+
syncRequest.setSelector(localSelector);
60+
}
61+
62+
stub.syncFlags(syncRequest.build(), new GrpcStreamHandler(streamReceiver));
63+
});
5564
}
5665

5766
/** Initialize gRPC stream connector. */
@@ -98,14 +107,9 @@ void observeEventStream(final BlockingQueue<QueuePayload> writeTo, final AtomicB
98107
Exception metadataException = null;
99108

100109
log.debug("Initializing sync stream request");
101-
final SyncFlagsRequest.Builder syncRequest = SyncFlagsRequest.newBuilder();
102110
final GetMetadataRequest.Builder metadataRequest = GetMetadataRequest.newBuilder();
103111
GetMetadataResponse metadataResponse = GetMetadataResponse.getDefaultInstance();
104112

105-
if (selector != null) {
106-
syncRequest.setSelector(selector);
107-
}
108-
109113
try (CancellableContext context = Context.current().withCancellation()) {
110114

111115
try {

providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/ProviderSteps.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ public ProviderSteps(State state) {
4040

4141
@BeforeAll
4242
public static void beforeAll() throws IOException {
43-
State.resolverType = Config.Resolver.RPC;
4443
sharedTempDir = Files.createDirectories(
4544
Paths.get("tmp/" + RandomStringUtils.randomAlphanumeric(8).toLowerCase() + "/"));
4645
container = new FlagdContainer()

0 commit comments

Comments
 (0)