Fix some linting issues

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java

@@ -38,7 +38,7 @@
  * GoFeatureFlagProvider is the JAVA provider implementation for the feature flag solution GO Feature Flag.
  */
 @Slf4j
-public class GoFeatureFlagProvider extends EventProvider implements Tracking {
+public final class GoFeatureFlagProvider extends EventProvider implements Tracking {
     /** Options to configure the provider. */
     private final GoFeatureFlagProviderOptions options;
     /** Service to evaluate the flags. */
@@ -60,7 +60,7 @@ public class GoFeatureFlagProvider extends EventProvider implements Tracking {
      * @param options - options to configure the provider
      * @throws InvalidOptions - if options are invalid
      */
-    public GoFeatureFlagProvider(GoFeatureFlagProviderOptions options) throws InvalidOptions {
+    public GoFeatureFlagProvider(final GoFeatureFlagProviderOptions options) throws InvalidOptions {
         Validator.providerOptions(options);
         this.options = options;
         this.api = GoFeatureFlagApi.builder().options(options).build();
@@ -92,7 +92,7 @@ public Metadata getMetadata() {
 
     @Override
     public List<Hook> getProviderHooks() {
-        return this.hooks;
+        return new ArrayList<>(this.hooks);
     }
 
     @Override

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java

@@ -26,6 +26,7 @@
 import dev.openfeature.sdk.exceptions.OpenFeatureError;
 import java.io.IOException;
 import java.net.HttpURLConnection;
+import java.text.SimpleDateFormat;
 import java.util.Collections;
 import java.util.Date;
 import java.util.List;
@@ -46,7 +47,7 @@
  * GoFeatureFlagApi is the class to contact the GO Feature Flag relay proxy.
  */
 @Slf4j
-public class GoFeatureFlagApi {
+public final class GoFeatureFlagApi {
     /** apiKey contains the token to use while calling GO Feature Flag relay proxy. */
     private final String apiKey;
 
@@ -56,7 +57,6 @@ public class GoFeatureFlagApi {
     /** parsedEndpoint is the endpoint of the GO Feature Flag relay proxy. */
     private final HttpUrl parsedEndpoint;
 
-
     /**
      * GoFeatureFlagController is the constructor of the controller to contact the GO Feature Flag
      * relay proxy.
@@ -92,7 +92,6 @@ private GoFeatureFlagApi(final GoFeatureFlagProviderOptions options) throws Inva
                 .build();
     }
 
-
     /**
      * evaluateFlag is calling the GO Feature Flag relay proxy to evaluate the feature flag.
      *
@@ -139,7 +138,6 @@ public GoFeatureFlagResponse evaluateFlag(final String key, final EvaluationCont
         }
     }
 
-
     /**
      * retrieveFlagConfiguration is calling the GO Feature Flag relay proxy to retrieve the flags'
      * configuration.
@@ -246,7 +244,8 @@ private FlagConfigResponse handleFlagConfigurationSuccess(final Response respons
         Date lastUpdated;
         try {
             val headerValue = response.header(Const.HTTP_HEADER_LAST_MODIFIED);
-            lastUpdated = headerValue != null ? Const.LAST_MODIFIED_HEADER_FORMATTER.parse(headerValue) : null;
+            val lastModifiedHeaderFormatter = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
+            lastUpdated = headerValue != null ? lastModifiedHeaderFormatter.parse(headerValue) : null;
         } catch (Exception e) {
             log.debug("Error parsing Last-Modified header: {}", e.getMessage());
             lastUpdated = null;
@@ -282,5 +281,4 @@ private <T> Request.Builder prepareHttpRequest(final HttpUrl url, final T reques
 
         return reqBuilder;
     }
-
 }

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/hook/DataCollectorHook.java

@@ -19,7 +19,7 @@
  * Flag.
  */
 @Slf4j
-public class DataCollectorHook implements Hook<HookContext<String>> {
+public final class DataCollectorHook implements Hook<HookContext<String>> {
     /** options contains all the options of this hook. */
     private final DataCollectorHookOptions options;
     /** eventsPublisher is the system collecting all the information to send to GO Feature Flag. */

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/service/EventsPublisher.java

@@ -15,7 +15,6 @@
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import java.util.function.Consumer;
 import lombok.extern.slf4j.Slf4j;
-import lombok.val;
 
 /**
  * Events publisher.
@@ -24,7 +23,7 @@
  * @author Liran Mendelovich
  */
 @Slf4j
-public class EventsPublisher<T> {
+public final class EventsPublisher<T> {
     public final AtomicBoolean isShutdown = new AtomicBoolean(false);
     private final int maxPendingEvents;
     private final Consumer<List<T>> publisher;
@@ -34,7 +33,7 @@ public class EventsPublisher<T> {
     private final Lock writeLock = readWriteLock.writeLock();
 
     private final ScheduledExecutorService scheduledExecutorService = Executors.newScheduledThreadPool(1);
-    private List<T> eventsList;
+    private final List<T> eventsList;
 
     /**
      * Constructor.
@@ -64,17 +63,28 @@ public void add(T event) {
             log.error("This object was shut down. Omitting event.");
             return;
         }
-        readLock.lock();
-        val shouldPublish = (eventsList != null) && (eventsList.size() >= maxPendingEvents);
-        readLock.unlock();
+
+        var shouldPublish = false;
+        try {
+            readLock.lock();
+            shouldPublish = (eventsList != null) && (eventsList.size() >= maxPendingEvents);
+        } finally {
+            readLock.unlock();
+        }
 
         if (shouldPublish) {
             log.warn("events collection is full. Publishing before adding new events.");
             publish();
         }
-        writeLock.lock();
-        eventsList.add(event);
-        writeLock.unlock();
+
+        try {
+            writeLock.lock();
+            if (eventsList != null) {
+                eventsList.add(event);
+            }
+        } finally {
+            writeLock.unlock();
+        }
     }
 
     /**

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/util/Const.java

@@ -2,8 +2,6 @@
 
 import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
-import java.text.DateFormat;
-import java.text.SimpleDateFormat;
 import java.time.Duration;
 
 /**
@@ -18,19 +16,14 @@ public class Const {
     public static final String HTTP_HEADER_ETAG = "ETag";
     public static final String HTTP_HEADER_IF_NONE_MATCH = "If-None-Match";
     public static final String HTTP_HEADER_LAST_MODIFIED = "Last-Modified";
-    public static final DateFormat LAST_MODIFIED_HEADER_FORMATTER =
-            new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
-
     // DEFAULT VALUES
     public static final long DEFAULT_POLLING_CONFIG_FLAG_CHANGE_INTERVAL_MS = 2L * 60L * 1000L;
     public static final long DEFAULT_FLUSH_INTERVAL_MS = Duration.ofMinutes(1).toMillis();
     public static final int DEFAULT_MAX_PENDING_EVENTS = 10000;
-
     // MAPPERS
     public static final ObjectMapper DESERIALIZE_OBJECT_MAPPER =
             new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
     public static final ObjectMapper SERIALIZE_OBJECT_MAPPER = new ObjectMapper();
     public static final ObjectMapper SERIALIZE_WASM_MAPPER = new ObjectMapper()
             .setSerializationInclusion(com.fasterxml.jackson.annotation.JsonInclude.Include.NON_NULL);
-
 }

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/wasm/EvaluationWasm.java

@@ -18,6 +18,7 @@
 import dev.openfeature.sdk.Reason;
 import java.io.File;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -28,7 +29,7 @@
  * EvaluationWasm is a class that represents the evaluation of a feature flag
  * it calls an external WASM module to evaluate the feature flag.
  */
-public class EvaluationWasm {
+public final class EvaluationWasm {
     private final Instance instance;
     private final ExportFunction evaluate;
     private final ExportFunction malloc;
@@ -99,22 +100,20 @@ private HostFunction getProcExitFunc() {
         });
     }
 
-
     /**
      * preWarmWasm is a function that is called to pre-warm the WASM module
      * It calls the malloc function to allocate memory for the WASM module
      * and then calls the free function to free the memory.
      */
     public void preWarmWasm() {
-        val message = "".getBytes();
+        val message = "".getBytes(StandardCharsets.UTF_8);
         Memory memory = this.instance.memory();
         int len = message.length;
         int ptr = (int) malloc.apply(len)[0];
         memory.write(ptr, message);
         this.free.apply(ptr, len);
     }
 
-
     /**
      * Evaluate is a function that evaluates the feature flag using the WASM module.
      *

providers/go-feature-flag/src/test/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderTest.java

@@ -411,7 +411,7 @@ void shouldResolveAValidObjectFlagWithTargetingMatchReason() {
             val got = client.getObjectDetails("object_key",
                     Value.objectToValue(new MutableStructure().add("default", "true")),
                     TestUtils.defaultEvaluationContext);
-            val want = FlagEvaluationDetails.<Object>builder()
+            val want = FlagEvaluationDetails.builder()
                     .value(Value.objectToValue(new MutableStructure().add("test", "false")))
                     .variant("varB")
                     .flagKey("object_key")