Fix some linting issues

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java

@@ -60,7 +60,7 @@ public class GoFeatureFlagProvider extends EventProvider implements Tracking {
      * @param options - options to configure the provider
      * @throws InvalidOptions - if options are invalid
      */
-    public GoFeatureFlagProvider(GoFeatureFlagProviderOptions options) throws InvalidOptions {
+    public GoFeatureFlagProvider(final GoFeatureFlagProviderOptions options) throws InvalidOptions {
         Validator.providerOptions(options);
         this.options = options;
         this.api = GoFeatureFlagApi.builder().options(options).build();
@@ -92,7 +92,7 @@ public Metadata getMetadata() {
 
     @Override
     public List<Hook> getProviderHooks() {
-        return this.hooks;
+        return new ArrayList<>(this.hooks);
     }
 
     @Override

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApi.java

@@ -56,7 +56,6 @@ public class GoFeatureFlagApi {
     /** parsedEndpoint is the endpoint of the GO Feature Flag relay proxy. */
     private final HttpUrl parsedEndpoint;
 
-
     /**
      * GoFeatureFlagController is the constructor of the controller to contact the GO Feature Flag
      * relay proxy.
@@ -92,7 +91,6 @@ private GoFeatureFlagApi(final GoFeatureFlagProviderOptions options) throws Inva
                 .build();
     }
 
-
     /**
      * evaluateFlag is calling the GO Feature Flag relay proxy to evaluate the feature flag.
      *
@@ -139,7 +137,6 @@ public GoFeatureFlagResponse evaluateFlag(final String key, final EvaluationCont
         }
     }
 
-
     /**
      * retrieveFlagConfiguration is calling the GO Feature Flag relay proxy to retrieve the flags'
      * configuration.
@@ -282,5 +279,4 @@ private <T> Request.Builder prepareHttpRequest(final HttpUrl url, final T reques
 
         return reqBuilder;
     }
-
 }

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/service/EventsPublisher.java

@@ -34,7 +34,7 @@ public class EventsPublisher<T> {
     private final Lock writeLock = readWriteLock.writeLock();
 
     private final ScheduledExecutorService scheduledExecutorService = Executors.newScheduledThreadPool(1);
-    private List<T> eventsList;
+    private final List<T> eventsList;
 
     /**
      * Constructor.
@@ -72,9 +72,14 @@ public void add(T event) {
             log.warn("events collection is full. Publishing before adding new events.");
             publish();
         }
-        writeLock.lock();
-        eventsList.add(event);
-        writeLock.unlock();
+        try {
+            writeLock.lock();
+            if (eventsList != null) {
+                eventsList.add(event);
+            }
+        } finally {
+            writeLock.unlock();
+        }
     }
 
     /**

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/util/Const.java

@@ -18,19 +18,16 @@ public class Const {
     public static final String HTTP_HEADER_ETAG = "ETag";
     public static final String HTTP_HEADER_IF_NONE_MATCH = "If-None-Match";
     public static final String HTTP_HEADER_LAST_MODIFIED = "Last-Modified";
-    public static final DateFormat LAST_MODIFIED_HEADER_FORMATTER =
-            new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
-
     // DEFAULT VALUES
     public static final long DEFAULT_POLLING_CONFIG_FLAG_CHANGE_INTERVAL_MS = 2L * 60L * 1000L;
     public static final long DEFAULT_FLUSH_INTERVAL_MS = Duration.ofMinutes(1).toMillis();
     public static final int DEFAULT_MAX_PENDING_EVENTS = 10000;
-
     // MAPPERS
     public static final ObjectMapper DESERIALIZE_OBJECT_MAPPER =
             new ObjectMapper().configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
     public static final ObjectMapper SERIALIZE_OBJECT_MAPPER = new ObjectMapper();
     public static final ObjectMapper SERIALIZE_WASM_MAPPER = new ObjectMapper()
             .setSerializationInclusion(com.fasterxml.jackson.annotation.JsonInclude.Include.NON_NULL);
-
+    public final DateFormat LAST_MODIFIED_HEADER_FORMATTER =
+            new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz");
 }

providers/go-feature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/wasm/EvaluationWasm.java

@@ -18,6 +18,7 @@
 import dev.openfeature.sdk.Reason;
 import java.io.File;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -99,22 +100,20 @@ private HostFunction getProcExitFunc() {
         });
     }
 
-
     /**
      * preWarmWasm is a function that is called to pre-warm the WASM module
      * It calls the malloc function to allocate memory for the WASM module
      * and then calls the free function to free the memory.
      */
     public void preWarmWasm() {
-        val message = "".getBytes();
+        val message = "".getBytes(StandardCharsets.UTF_8);
         Memory memory = this.instance.memory();
         int len = message.length;
         int ptr = (int) malloc.apply(len)[0];
         memory.write(ptr, message);
         this.free.apply(ptr, len);
     }
 
-
     /**
      * Evaluate is a function that evaluates the feature flag using the WASM module.
      *