test(flagd): add envoy test #1582
Conversation
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @aepfli, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the testing capabilities for the flagd provider by introducing comprehensive end-to-end tests for Envoy proxy integration. It achieves this by refactoring the test infrastructure to utilize Testcontainers with docker-compose, providing a more robust and scalable way to orchestrate test environments for flagd and its dependencies like Envoy.
Highlights
- Test Infrastructure Refactor: Migrated flagd end-to-end tests from a custom
FlagdContainertoTestcontainers'ComposeContainer, leveragingdocker-composefor more robust test environment orchestration. - Envoy Proxy Test Integration: Introduced new test cases and setup to validate flagd integration with an Envoy proxy, specifically handling
targetURIconfigurations for proxy-based flag resolution. - Centralized Test Harness: Updated the
test-harnesssubmodule to include the necessarydocker-compose.yamland related configurations for the new Envoy testing setup, consolidating previously scattered configuration files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
aepfli
force-pushed
the
test/add_envoy_again
branch
from
b3606f9 to
255cf40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aepfli
force-pushed
the
test/add_envoy_again
branch
from
255cf40 to
217b6e0
Compare
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
test/add_envoy_again
branch
from
01839dd to
2227aea
Compare
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the test setup to use docker-compose for managing flagd and envoy containers, which is a great improvement for test infrastructure maintainability and enables new tests for envoy. The code changes are mostly adapting the test steps to this new container setup. I've identified a couple of areas for improvement in the new ContainerUtil class to make it more robust and maintainable.
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerUtil.java
Show resolved
Hide resolved
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerUtil.java
Show resolved
Hide resolved
6 participants
adding docker compose yaml for envoy testing
blocked by: open-feature/flagd-testbed#283