Skip to content

fix: race condition causing default when multiple flags are used #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: race condition causing default when multiple flags are used #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...re/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/OpenFeatureExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public void beforeEach(ExtensionContext extensionContext) throws Exception {
((TestProvider) api.getProvider(domain))
.addConfigurationForTest(getNamespace(extensionContext), stringMapEntry.getValue());
} else {
api.setProvider(domain, new TestProvider(
api.setProviderAndWait(domain, new TestProvider(
getNamespace(extensionContext),
stringMapEntry.getValue()));
}
Expand All @@ -128,7 +128,7 @@ public void beforeEach(ExtensionContext extensionContext) throws Exception {
((TestProvider) api.getProvider())
.addConfigurationForTest(getNamespace(extensionContext), stringMapEntry.getValue());
} else {
api.setProvider(new TestProvider(
api.setProviderAndWait(new TestProvider(
getNamespace(extensionContext),
stringMapEntry.getValue()));
}
Expand Down
27 changes: 5 additions & 22 deletions ...penfeature/src/main/java/dev/openfeature/contrib/tools/junitopenfeature/TestProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
package dev.openfeature.contrib.tools.junitopenfeature;

import java.util.HashMap;
import java.util.Map;

import org.junit.jupiter.api.extension.ExtensionContext;

import dev.openfeature.sdk.EvaluationContext;
import dev.openfeature.sdk.EventProvider;
import dev.openfeature.sdk.ImmutableContext;
import dev.openfeature.sdk.Metadata;
import dev.openfeature.sdk.ProviderEvaluation;
import dev.openfeature.sdk.ProviderState;
import dev.openfeature.sdk.Value;
import dev.openfeature.sdk.providers.memory.Flag;
import dev.openfeature.sdk.providers.memory.InMemoryProvider;
import lombok.Getter;
import lombok.SneakyThrows;
import lombok.extern.slf4j.Slf4j;
import org.junit.jupiter.api.extension.ExtensionContext;

import java.util.HashMap;
import java.util.Map;

/**
* TestProvider based on InMemoryProvider but with another dimension added to the maps of flags.
Expand Down Expand Up @@ -102,23 +102,6 @@ public ProviderEvaluation<Value> getObjectEvaluation(String key, Value defaultVa
.getObjectEvaluation(key, defaultValue, evaluationContext);
}

@Override
public ProviderState getState() {
return providerMap
.values()
.stream()
.map(InMemoryProvider::getState)
.reduce(
(providerState, providerState2) -> {
if (providerState.ordinal() < providerState2.ordinal()) {
return providerState2;
}
return providerState;
}
)
.orElse(ProviderState.READY);
}

public static void setCurrentNamespace(ExtensionContext.Namespace namespace) {
CURRENT_NAMESPACE.set(namespace);
}
Expand Down