Skip to content

Commit 1d82637

Browse files
committed
Remove hook evaluation. Not in the spec anymore
1 parent 4d2de56 commit 1d82637

File tree

3 files changed

+2
-31
lines changed

3 files changed

+2
-31
lines changed

lib/src/main/java/javasdk/FlagEvaluationDetails.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,14 @@
88
@Data @Builder
99
public class FlagEvaluationDetails<T> implements BaseEvaluation<T> {
1010
String flagKey;
11-
HookEvaluation executedHooks;
1211
T value;
1312
@Nullable String variant;
1413
Reason reason;
1514
@Nullable ErrorCode errorCode;
1615

17-
public static <T> FlagEvaluationDetails<T> from(ProviderEvaluation<T> providerEval, String flagKey, HookEvaluation executedHooks) {
16+
public static <T> FlagEvaluationDetails<T> from(ProviderEvaluation<T> providerEval, String flagKey) {
1817
return FlagEvaluationDetails.<T>builder()
1918
.flagKey(flagKey)
20-
.executedHooks(executedHooks)
2119
.value(providerEval.getValue())
2220
.variant(providerEval.getVariant())
2321
.reason(providerEval.getReason())

lib/src/main/java/javasdk/HookEvaluation.java

Lines changed: 0 additions & 27 deletions
This file was deleted.

lib/src/main/java/javasdk/OpenFeatureClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ <T> FlagEvaluationDetails<T> evaluateFlag(FlagValueType type, String key, T defa
6767
throw new GeneralError("Unknown flag type");
6868
}
6969

70-
details = FlagEvaluationDetails.from(providerEval, key, null);
70+
details = FlagEvaluationDetails.from(providerEval, key);
7171
this.afterHooks(hookCtx, details, mergedHooks, hints);
7272
} catch (Exception e) {
7373
log.error("Unable to correctly evaluate flag with key {} due to exception {}", key, e.getMessage());

0 commit comments

Comments
 (0)