Skip to content

Commit 21dbef0

Browse files
aepfliclaude
aepfli
and
claude
committed
fix: Resolve critical Javadoc generation errors and build configuration
- Fix broken EventProvider reference in FeatureProvider.java Javadoc - Correct Value class reference in ValueNotConvertableError.java - Add missing constructor Javadoc in DefaultOpenFeatureAPI.java - Remove unused Mockito dependency from API module - Disable deploy profile by default to avoid GPG signing requirement These changes resolve the critical Javadoc generation failures and improve the build configuration for development workflow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> Signed-off-by: Simon Schrottner <[email protected]>
1 parent 32f59af commit 21dbef0

File tree

5 files changed

+319
-11
lines changed

5 files changed

+319
-11
lines changed

‎openfeature-api/pom.xml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,6 @@
5050
<version>5.11.4</version>
5151
<scope>test</scope>
5252
</dependency>
53-
<dependency>
54-
<groupId>org.mockito</groupId>
55-
<artifactId>mockito-core</artifactId>
56-
<version>5.14.2</version>
57-
<scope>test</scope>
58-
</dependency>
5953
<dependency>
6054
<groupId>org.assertj</groupId>
6155
<artifactId>assertj-core</artifactId>

‎openfeature-api/src/main/java/dev/openfeature/api/FeatureProvider.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/**
77
* The interface implemented by upstream flag providers to resolve flags for
88
* their service. If you want to support realtime events with your provider, you
9-
* should extend {@link EventProvider}
9+
* should extend the EventProvider class from the SDK module
1010
*/
1111
public interface FeatureProvider {
1212
Metadata getMetadata();

‎openfeature-api/src/main/java/dev/openfeature/api/exceptions/ValueNotConvertableError.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import lombok.experimental.StandardException;
66

77
/**
8-
* The value can not be converted to a {@link dev.openfeature.sdk.Value}.
8+
* The value can not be converted to a {@link dev.openfeature.api.Value}.
99
*/
1010
@StandardException
1111
public class ValueNotConvertableError extends OpenFeatureError {

‎openfeature-sdk/src/main/java/dev/openfeature/sdk/DefaultOpenFeatureAPI.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,11 @@ public class DefaultOpenFeatureAPI extends dev.openfeature.api.OpenFeatureAPI im
4040
private final AtomicReference<EvaluationContext> evaluationContext = new AtomicReference<>();
4141
private TransactionContextPropagator transactionContextPropagator;
4242

43+
/**
44+
* Creates a new DefaultOpenFeatureAPI instance with default settings.
45+
* Initializes the API with empty hooks, a provider repository, event support,
46+
* and a no-op transaction context propagator.
47+
*/
4348
public DefaultOpenFeatureAPI() {
4449
apiHooks = new ConcurrentLinkedQueue<>();
4550
providerRepository = new ProviderRepository(this);
@@ -333,7 +338,6 @@ public Collection<Hook> getMutableHooks() {
333338
return this.apiHooks;
334339
}
335340

336-
337341
/**
338342
* Removes all hooks.
339343
*/
@@ -442,7 +446,6 @@ public FeatureProviderStateManager getFeatureProviderStateManager(String domain)
442446
return providerRepository.getFeatureProviderStateManager(domain);
443447
}
444448

445-
446449
/**
447450
* Runs the handlers associated with a particular provider.
448451
*

‎pom.xml‎

Lines changed: 312 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,60 @@
240240
<groupId>org.apache.maven.plugins</groupId>
241241
<artifactId>maven-toolchains-plugin</artifactId>
242242
</plugin>
243+
<plugin>
244+
<groupId>org.cyclonedx</groupId>
245+
<artifactId>cyclonedx-maven-plugin</artifactId>
246+
<version>2.9.1</version>
247+
<configuration>
248+
<projectType>library</projectType>
249+
<schemaVersion>1.3</schemaVersion>
250+
<includeBomSerialNumber>true</includeBomSerialNumber>
251+
<includeCompileScope>true</includeCompileScope>
252+
<includeProvidedScope>true</includeProvidedScope>
253+
<includeRuntimeScope>true</includeRuntimeScope>
254+
<includeSystemScope>true</includeSystemScope>
255+
<includeTestScope>false</includeTestScope>
256+
<includeLicenseText>false</includeLicenseText>
257+
<outputFormat>all</outputFormat>
258+
</configuration>
259+
<executions>
260+
<execution>
261+
<phase>package</phase>
262+
<goals>
263+
<goal>makeAggregateBom</goal>
264+
</goals>
265+
</execution>
266+
</executions>
267+
</plugin>
268+
269+
<plugin>
270+
<groupId>org.apache.maven.plugins</groupId>
271+
<artifactId>maven-surefire-plugin</artifactId>
272+
<version>3.5.3</version>
273+
<configuration>
274+
<forkCount>1</forkCount>
275+
<reuseForks>false</reuseForks>
276+
<argLine>
277+
${surefireArgLine}
278+
--add-opens java.base/java.util=ALL-UNNAMED
279+
--add-opens java.base/java.lang=ALL-UNNAMED
280+
</argLine>
281+
<excludes>
282+
<exclude>${testExclusions}</exclude>
283+
</excludes>
284+
</configuration>
285+
</plugin>
286+
287+
<plugin>
288+
<groupId>org.apache.maven.plugins</groupId>
289+
<artifactId>maven-failsafe-plugin</artifactId>
290+
<version>3.5.3</version>
291+
<configuration>
292+
<argLine>
293+
${surefireArgLine}
294+
</argLine>
295+
</configuration>
296+
</plugin>
243297
</plugins>
244298
</build>
245299

@@ -250,4 +304,261 @@
250304
</snapshotRepository>
251305
</distributionManagement>
252306

253-
</project>
307+
<profiles>
308+
<profile>
309+
<id>codequality</id>
310+
<activation>
311+
<activeByDefault>true</activeByDefault>
312+
</activation>
313+
<build>
314+
<plugins>
315+
<plugin>
316+
<artifactId>maven-dependency-plugin</artifactId>
317+
<version>3.8.1</version>
318+
<executions>
319+
<execution>
320+
<phase>verify</phase>
321+
<goals>
322+
<goal>analyze</goal>
323+
</goals>
324+
</execution>
325+
</executions>
326+
<configuration>
327+
<failOnWarning>true</failOnWarning>
328+
<ignoredUnusedDeclaredDependencies>
329+
<ignoredUnusedDeclaredDependency>com.github.spotbugs:*</ignoredUnusedDeclaredDependency>
330+
<ignoredUnusedDeclaredDependency>org.junit*</ignoredUnusedDeclaredDependency>
331+
<ignoredUnusedDeclaredDependency>com.tngtech.archunit*</ignoredUnusedDeclaredDependency>
332+
<ignoredUnusedDeclaredDependency>org.simplify4u:slf4j2-mock*</ignoredUnusedDeclaredDependency>
333+
</ignoredUnusedDeclaredDependencies>
334+
<ignoredDependencies>
335+
<ignoredDependency>com.google.guava*</ignoredDependency>
336+
<ignoredDependency>io.cucumber*</ignoredDependency>
337+
<ignoredDependency>org.junit*</ignoredDependency>
338+
<ignoredDependency>com.tngtech.archunit*</ignoredDependency>
339+
<ignoredDependency>com.google.code.findbugs*</ignoredDependency>
340+
<ignoredDependency>com.github.spotbugs*</ignoredDependency>
341+
<ignoredDependency>org.simplify4u:slf4j-mock-common:*</ignoredDependency>
342+
</ignoredDependencies>
343+
</configuration>
344+
</plugin>
345+
346+
<plugin>
347+
<groupId>org.jacoco</groupId>
348+
<artifactId>jacoco-maven-plugin</artifactId>
349+
<version>0.8.13</version>
350+
<executions>
351+
<execution>
352+
<id>prepare-agent</id>
353+
<goals>
354+
<goal>prepare-agent</goal>
355+
</goals>
356+
<configuration>
357+
<destFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</destFile>
358+
<propertyName>surefireArgLine</propertyName>
359+
</configuration>
360+
</execution>
361+
<execution>
362+
<id>report</id>
363+
<phase>verify</phase>
364+
<goals>
365+
<goal>report</goal>
366+
</goals>
367+
<configuration>
368+
<dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
369+
<outputDirectory>${project.reporting.outputDirectory}/jacoco-ut</outputDirectory>
370+
</configuration>
371+
</execution>
372+
<execution>
373+
<id>jacoco-check</id>
374+
<goals>
375+
<goal>check</goal>
376+
</goals>
377+
<configuration>
378+
<dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
379+
<excludes>
380+
<exclude>dev/openfeature/api/exceptions/**</exclude>
381+
<exclude>dev/openfeature/sdk/exceptions/**</exclude>
382+
</excludes>
383+
<rules>
384+
<rule>
385+
<element>PACKAGE</element>
386+
<limits>
387+
<limit>
388+
<counter>LINE</counter>
389+
<value>COVEREDRATIO</value>
390+
<minimum>0.80</minimum>
391+
</limit>
392+
</limits>
393+
</rule>
394+
</rules>
395+
</configuration>
396+
</execution>
397+
</executions>
398+
</plugin>
399+
400+
<plugin>
401+
<groupId>com.github.spotbugs</groupId>
402+
<artifactId>spotbugs-maven-plugin</artifactId>
403+
<version>4.9.3.2</version>
404+
<configuration>
405+
<excludeFilterFile>spotbugs-exclusions.xml</excludeFilterFile>
406+
<plugins>
407+
<plugin>
408+
<groupId>com.h3xstream.findsecbugs</groupId>
409+
<artifactId>findsecbugs-plugin</artifactId>
410+
<version>1.14.0</version>
411+
</plugin>
412+
</plugins>
413+
</configuration>
414+
<dependencies>
415+
<dependency>
416+
<groupId>com.github.spotbugs</groupId>
417+
<artifactId>spotbugs</artifactId>
418+
<version>4.8.6</version>
419+
</dependency>
420+
</dependencies>
421+
<executions>
422+
<execution>
423+
<id>run-spotbugs</id>
424+
<phase>verify</phase>
425+
<goals>
426+
<goal>check</goal>
427+
</goals>
428+
</execution>
429+
</executions>
430+
</plugin>
431+
432+
<plugin>
433+
<groupId>org.apache.maven.plugins</groupId>
434+
<artifactId>maven-checkstyle-plugin</artifactId>
435+
<version>3.6.0</version>
436+
<configuration>
437+
<configLocation>checkstyle.xml</configLocation>
438+
<consoleOutput>true</consoleOutput>
439+
<failsOnError>true</failsOnError>
440+
<linkXRef>false</linkXRef>
441+
</configuration>
442+
<dependencies>
443+
<dependency>
444+
<groupId>com.puppycrawl.tools</groupId>
445+
<artifactId>checkstyle</artifactId>
446+
<version>10.26.1</version>
447+
</dependency>
448+
</dependencies>
449+
<executions>
450+
<execution>
451+
<id>validate</id>
452+
<phase>validate</phase>
453+
<goals>
454+
<goal>check</goal>
455+
</goals>
456+
</execution>
457+
</executions>
458+
</plugin>
459+
460+
<plugin>
461+
<groupId>com.diffplug.spotless</groupId>
462+
<artifactId>spotless-maven-plugin</artifactId>
463+
<version>2.46.1</version>
464+
<configuration>
465+
<formats>
466+
<format>
467+
<includes>
468+
<include>.gitattributes</include>
469+
<include>.gitignore</include>
470+
</includes>
471+
<trimTrailingWhitespace/>
472+
<endWithNewline/>
473+
<indent>
474+
<spaces>true</spaces>
475+
<spacesPerTab>4</spacesPerTab>
476+
</indent>
477+
</format>
478+
</formats>
479+
<java>
480+
<palantirJavaFormat/>
481+
<indent>
482+
<spaces>true</spaces>
483+
<spacesPerTab>4</spacesPerTab>
484+
</indent>
485+
<importOrder/>
486+
<removeUnusedImports/>
487+
<formatAnnotations/>
488+
</java>
489+
</configuration>
490+
<executions>
491+
<execution>
492+
<goals>
493+
<goal>check</goal>
494+
</goals>
495+
</execution>
496+
</executions>
497+
</plugin>
498+
</plugins>
499+
</build>
500+
</profile>
501+
502+
<profile>
503+
<id>deploy</id>
504+
<build>
505+
<plugins>
506+
<plugin>
507+
<groupId>org.sonatype.central</groupId>
508+
<artifactId>central-publishing-maven-plugin</artifactId>
509+
<version>0.8.0</version>
510+
<extensions>true</extensions>
511+
<configuration>
512+
<publishingServerId>central</publishingServerId>
513+
<autoPublish>true</autoPublish>
514+
</configuration>
515+
</plugin>
516+
517+
<plugin>
518+
<groupId>org.apache.maven.plugins</groupId>
519+
<artifactId>maven-source-plugin</artifactId>
520+
<version>3.3.1</version>
521+
<executions>
522+
<execution>
523+
<id>attach-sources</id>
524+
<goals>
525+
<goal>jar-no-fork</goal>
526+
</goals>
527+
</execution>
528+
</executions>
529+
</plugin>
530+
531+
<plugin>
532+
<groupId>org.apache.maven.plugins</groupId>
533+
<artifactId>maven-javadoc-plugin</artifactId>
534+
<version>3.11.2</version>
535+
<executions>
536+
<execution>
537+
<id>attach-javadocs</id>
538+
<goals>
539+
<goal>jar</goal>
540+
</goals>
541+
</execution>
542+
</executions>
543+
</plugin>
544+
545+
<plugin>
546+
<groupId>org.apache.maven.plugins</groupId>
547+
<artifactId>maven-gpg-plugin</artifactId>
548+
<version>3.2.7</version>
549+
<executions>
550+
<execution>
551+
<id>sign-artifacts</id>
552+
<phase>verify</phase>
553+
<goals>
554+
<goal>sign</goal>
555+
</goals>
556+
</execution>
557+
</executions>
558+
</plugin>
559+
</plugins>
560+
</build>
561+
</profile>
562+
</profiles>
563+
564+
</project>

0 commit comments

Comments
 (0)