registerHooks -> addHooks. Fixes #9

Author: justinabrahms

lib/src/main/java/dev/openfeature/javasdk/FlagEvaluationLifecycle.java

@@ -3,6 +3,6 @@
 import java.util.List;
 
 public interface FlagEvaluationLifecycle {
-    void registerHooks(Hook... hooks);
+    void addHooks(Hook... hooks);
     List<Hook> getClientHooks();
 }

lib/src/main/java/dev/openfeature/javasdk/OpenFeatureAPI.java

@@ -38,7 +38,7 @@ public Client getClient(@Nullable String name, @Nullable String version) {
         return new OpenFeatureClient(this, name, version);
     }
 
-    public void registerHooks(Hook... hooks) {
+    public void addHooks(Hook... hooks) {
         this.apiHooks.addAll(Arrays.asList(hooks));
     }
 

lib/src/main/java/dev/openfeature/javasdk/OpenFeatureClient.java

@@ -29,7 +29,7 @@ public OpenFeatureClient(OpenFeatureAPI openFeatureAPI, String name, String vers
     }
 
     @Override
-    public void registerHooks(Hook... hooks) {
+    public void addHooks(Hook... hooks) {
         this.clientHooks.addAll(Arrays.asList(hooks));
     }
 

lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java

@@ -27,7 +27,7 @@ class DeveloperExperienceTest {
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
         api.setProvider(new NoOpProvider());
         Client client = api.getClient();
-        client.registerHooks(exampleHook);
+        client.addHooks(exampleHook);
         Boolean retval = client.getBooleanValue(flagKey, false);
         verify(exampleHook, times(1)).finallyAfter(any(), any());
         assertFalse(retval);
@@ -40,7 +40,7 @@ class DeveloperExperienceTest {
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
         api.setProvider(new NoOpProvider());
         Client client = api.getClient();
-        client.registerHooks(clientHook);
+        client.addHooks(clientHook);
         Boolean retval = client.getBooleanValue(flagKey, false, null,
                 FlagEvaluationOptions.builder().hook(evalHook).build());
         verify(clientHook, times(1)).finallyAfter(any(), any());

lib/src/test/java/dev/openfeature/javasdk/FlagEvaluationSpecTests.java

@@ -42,12 +42,12 @@ Client _client() {
         Hook h1 = mock(Hook.class);
         Hook h2 = mock(Hook.class);
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.registerHooks(h1);
+        api.addHooks(h1);
 
         assertEquals(1, api.getApiHooks().size());
         assertEquals(h1, api.getApiHooks().get(0));
 
-        api.registerHooks(h2);
+        api.addHooks(h2);
         assertEquals(2, api.getApiHooks().size());
         assertEquals(h2, api.getApiHooks().get(1));
     }
@@ -67,8 +67,8 @@ Client _client() {
         Client c = _client();
         Hook m1 = mock(Hook.class);
         Hook m2 = mock(Hook.class);
-        c.registerHooks(m1);
-        c.registerHooks(m2);
+        c.addHooks(m1);
+        c.addHooks(m2);
         List<Hook> hooks = c.getClientHooks();
         assertEquals(2, hooks.size());
         assertTrue(hooks.contains(m1));
@@ -142,7 +142,7 @@ Client _client() {
         Client c = _client();
         Hook clientHook = mock(Hook.class);
         Hook invocationHook = mock(Hook.class);
-        c.registerHooks(clientHook);
+        c.addHooks(clientHook);
         c.getBooleanValue("key", false, null, FlagEvaluationOptions.builder()
                         .hook(invocationHook)
                         .build());

lib/src/test/java/dev/openfeature/javasdk/HookSpecTests.java

@@ -195,7 +195,7 @@ void emptyApiHooks() {
         List<String> evalOrder = new ArrayList<String>();
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
         api.setProvider(new NoOpProvider());
-        api.registerHooks(new Hook<Boolean>() {
+        api.addHooks(new Hook<Boolean>() {
             @Override
             public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) {
                 evalOrder.add("api before");
@@ -220,7 +220,7 @@ public void finallyAfter(HookContext<Boolean> ctx, ImmutableMap<String, Object>
         });
 
         Client c = api.getClient();
-        c.registerHooks(new Hook<Boolean>() {
+        c.addHooks(new Hook<Boolean>() {
             @Override
             public Optional<EvaluationContext> before(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints) {
                 evalOrder.add("client before");