fixup: add missing steps and adapt to new spec steps

Signed-off-by: Simon Schrottner <[email protected]>

Author: aepfli

spec

@@ -20,4 +20,5 @@ public class Flag<T> {
     private String defaultVariant;
     private ContextEvaluator<T> contextEvaluator;
     private ImmutableMetadata flagMetadata;
+    private boolean disabled;
 }

src/main/java/dev/openfeature/sdk/providers/memory/Flag.java

@@ -1,5 +1,6 @@
 package dev.openfeature.sdk.providers.memory;
 
+import dev.openfeature.sdk.ErrorCode;
 import dev.openfeature.sdk.EvaluationContext;
 import dev.openfeature.sdk.EventProvider;
 import dev.openfeature.sdk.Metadata;
@@ -97,36 +98,36 @@ public void updateFlag(String flagKey, Flag<?> newFlag) {
     @Override
     public ProviderEvaluation<Boolean> getBooleanEvaluation(
             String key, Boolean defaultValue, EvaluationContext evaluationContext) {
-        return getEvaluation(key, evaluationContext, Boolean.class);
+        return getEvaluation(key, defaultValue, evaluationContext, Boolean.class);
     }
 
     @Override
     public ProviderEvaluation<String> getStringEvaluation(
             String key, String defaultValue, EvaluationContext evaluationContext) {
-        return getEvaluation(key, evaluationContext, String.class);
+        return getEvaluation(key, defaultValue, evaluationContext, String.class);
     }
 
     @Override
     public ProviderEvaluation<Integer> getIntegerEvaluation(
             String key, Integer defaultValue, EvaluationContext evaluationContext) {
-        return getEvaluation(key, evaluationContext, Integer.class);
+        return getEvaluation(key, defaultValue, evaluationContext, Integer.class);
     }
 
     @Override
     public ProviderEvaluation<Double> getDoubleEvaluation(
             String key, Double defaultValue, EvaluationContext evaluationContext) {
-        return getEvaluation(key, evaluationContext, Double.class);
+        return getEvaluation(key, defaultValue, evaluationContext, Double.class);
     }
 
     @SneakyThrows
     @Override
     public ProviderEvaluation<Value> getObjectEvaluation(
             String key, Value defaultValue, EvaluationContext evaluationContext) {
-        return getEvaluation(key, evaluationContext, Value.class);
+        return getEvaluation(key, defaultValue, evaluationContext, Value.class);
     }
 
     private <T> ProviderEvaluation<T> getEvaluation(
-            String key, EvaluationContext evaluationContext, Class<?> expectedType) throws OpenFeatureError {
+            String key, T defaultValue, EvaluationContext evaluationContext, Class<?> expectedType) throws OpenFeatureError {
         if (!ProviderState.READY.equals(state)) {
             if (ProviderState.NOT_READY.equals(state)) {
                 throw new ProviderNotReadyError("provider not yet initialized");
@@ -140,6 +141,13 @@ private <T> ProviderEvaluation<T> getEvaluation(
         if (flag == null) {
             throw new FlagNotFoundError("flag " + key + " not found");
         }
+        if (flag.isDisabled()) {
+            return ProviderEvaluation.<T>builder()
+                    .reason(Reason.DISABLED.name())
+                    .value(defaultValue)
+                    .flagMetadata(flag.getFlagMetadata())
+                    .build();
+        }
         T value;
         Reason reason = Reason.STATIC;
         if (flag.getContextEvaluator() != null) {

src/main/java/dev/openfeature/sdk/providers/memory/InMemoryProvider.java

@@ -16,5 +16,5 @@
 @ConfigurationParameter(key = PLUGIN_PROPERTY_NAME, value = "pretty")
 @ConfigurationParameter(key = GLUE_PROPERTY_NAME, value = "dev.openfeature.sdk.e2e.steps")
 @ConfigurationParameter(key = OBJECT_FACTORY_PROPERTY_NAME, value = "io.cucumber.picocontainer.PicoFactory")
-@ExcludeTags({"deprecated", "reason-codes", "async", "immutability", "evaluation-options"})
+@ExcludeTags({"deprecated", "reason-codes-cached", "async", "immutability", "evaluation-options"})
 public class GherkinSpecTest {}

src/test/java/dev/openfeature/sdk/e2e/GherkinSpecTest.java

@@ -24,7 +24,7 @@ public FlagStepDefinitions(State state) {
         this.state = state;
     }
 
-    @Given("a {}-flag with key {string} and a default value {string}")
+    @Given("a {}-flag with key {string} and a fallback value {string}")
     public void givenAFlag(String type, String name, String defaultValue) {
         state.flag = new Flag(type, name, Utils.convert(defaultValue, type));
     }