Skip to content

Commit 3e11560

Browse files
committed
-addresses review suggestion
1 parent eb85925 commit 3e11560

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

lib/src/main/java/dev/openfeature/javasdk/HookSupport.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,17 @@ private <T> void executeHooks(
3232
) {
3333
hooks
3434
.stream()
35-
.filter(hook -> isHookCompatible(flagValueType, hook))
35+
.filter(hook -> hook.supportsFlagValueType(flagValueType))
3636
.forEach(hook -> executeChecked(hook, hookCode, hookMethod));
3737
}
3838

39-
private boolean isHookCompatible(FlagValueType flagValueType, Hook hook) {
40-
return hook.supportsFlagValueType(flagValueType);
41-
}
42-
4339
private <T> void executeHooksUnchecked(
4440
FlagValueType flagValueType, List<Hook> hooks,
4541
Consumer<Hook<T>> hookCode
4642
) {
4743
hooks
4844
.stream()
49-
.filter(hook -> isHookCompatible(flagValueType, hook))
45+
.filter(hook -> hook.supportsFlagValueType(flagValueType))
5046
.forEach(hookCode::accept);
5147
}
5248

@@ -68,7 +64,7 @@ private Stream<EvaluationContext> callBeforeHooks(FlagValueType flagValueType, H
6864
return Lists
6965
.reverse(hooks)
7066
.stream()
71-
.filter(hook -> isHookCompatible(flagValueType, hook))
67+
.filter(hook -> hook.supportsFlagValueType(flagValueType))
7268
.map(hook -> hook.before(hookCtx, hints))
7369
.filter(Objects::nonNull)
7470
.filter(Optional::isPresent)

0 commit comments

Comments
 (0)