-changes contract of Hook.supportsFlagValueType to take in current evaluated feature flag

Author: lopitz

lib/src/main/java/dev/openfeature/javasdk/BooleanHook.java

@@ -3,7 +3,7 @@
 public interface BooleanHook extends Hook<Boolean> {
 
     @Override
-    default FlagValueType supportsFlagValueType() {
-        return FlagValueType.BOOLEAN;
+    default boolean supportsFlagValueType(FlagValueType flagValueType) {
+        return FlagValueType.BOOLEAN == flagValueType;
     }
 }

lib/src/main/java/dev/openfeature/javasdk/Hook.java

@@ -49,7 +49,7 @@ default void error(HookContext<T> ctx, Exception error, Map<String, Object> hint
     default void finallyAfter(HookContext<T> ctx, Map<String, Object> hints) {
     }
 
-    default FlagValueType supportsFlagValueType() {
-        return FlagValueType.OBJECT;
+    default boolean supportsFlagValueType(FlagValueType flagValueType) {
+        return true;
     }
 }

lib/src/main/java/dev/openfeature/javasdk/HookSupport.java

@@ -37,7 +37,7 @@ private <T> void executeHooks(
     }
 
     private boolean isHookCompatible(FlagValueType flagValueType, Hook hook) {
-        return hook.supportsFlagValueType() == flagValueType || hook.supportsFlagValueType() == FlagValueType.OBJECT;
+        return hook.supportsFlagValueType(flagValueType);
     }
 
     private <T> void executeHooksUnchecked(

lib/src/main/java/dev/openfeature/javasdk/IntegerHook.java

@@ -3,7 +3,7 @@
 public interface IntegerHook extends Hook<Integer> {
 
     @Override
-    default FlagValueType supportsFlagValueType() {
-        return FlagValueType.INTEGER;
+    default boolean supportsFlagValueType(FlagValueType flagValueType) {
+        return FlagValueType.INTEGER == flagValueType;
     }
 }

lib/src/main/java/dev/openfeature/javasdk/StringHook.java

@@ -3,7 +3,7 @@
 public interface StringHook extends Hook<String> {
 
     @Override
-    default FlagValueType supportsFlagValueType() {
-        return FlagValueType.STRING;
+    default boolean supportsFlagValueType(FlagValueType flagValueType) {
+        return FlagValueType.STRING == flagValueType;
     }
 }

lib/src/test/java/dev/openfeature/javasdk/DeveloperExperienceTest.java

@@ -1,5 +1,6 @@
 package dev.openfeature.javasdk;
 
+import dev.openfeature.javasdk.fixtures.HookFixtures;
 import org.junit.jupiter.api.Test;
 import org.mockito.Mockito;
 
@@ -10,7 +11,7 @@
 
 
 @SuppressWarnings("unchecked")
-class DeveloperExperienceTest {
+class DeveloperExperienceTest implements HookFixtures {
     transient String flagKey = "mykey";
     @Test void simpleBooleanFlag() {
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
@@ -21,7 +22,7 @@ class DeveloperExperienceTest {
     }
 
     @Test void clientHooks() {
-        Hook<Boolean> exampleHook = createBooleanHook();
+        Hook<Boolean> exampleHook = mockBooleanHook();
 
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
         api.setProvider(new NoOpProvider());
@@ -32,15 +33,9 @@ class DeveloperExperienceTest {
         assertFalse(retval);
     }
 
-    private Hook<Boolean> createBooleanHook() {
-        Hook hook = mock(Hook.class);
-        when(hook.supportsFlagValueType()).thenReturn(FlagValueType.BOOLEAN);
-        return hook;
-    }
-
     @Test void evalHooks() {
-        Hook<Boolean> clientHook = createBooleanHook();
-        Hook<Boolean> evalHook = createBooleanHook();
+        Hook<Boolean> clientHook = mockBooleanHook();
+        Hook<Boolean> evalHook = mockBooleanHook();
 
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
         api.setProvider(new NoOpProvider());