Skip to content

Commit 5e30d12

Browse files
committed
Multiprovider: review comments incorporated
Signed-off-by: suvaidkhan <[email protected]>
1 parent dd809d2 commit 5e30d12

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

src/main/java/dev/openfeature/sdk/multiprovider/MultiProvider.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ public void initialize(EvaluationContext evaluationContext) throws Exception {
9595
List<Future<Boolean>> results = initPool.invokeAll(tasks);
9696
for (Future<Boolean> result : results) {
9797
if (!result.get()) {
98+
initPool.shutdown();
9899
throw new GeneralError("init failed");
99100
}
100101
}

src/test/java/dev/openfeature/sdk/multiProvider/MultiProviderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ void shouldInitializeSuccessfully() {
4141
MultiProvider multiProvider = new MultiProvider(providers, strategy);
4242
multiProvider.initialize(null);
4343

44-
assertNotNull(multiProvider);
4544
MultiProviderMetadata metadata = (MultiProviderMetadata) multiProvider.getMetadata();
4645
Map<String, Metadata> map = metadata.getOriginalMetadata();
4746
assertEquals(mockMetaData1, map.get(mockProvider1.getMetadata().getName()));

0 commit comments

Comments
 (0)