No op provider isn't generic. Has tests

Author: justinabrahms

lib/src/main/java/javasdk/NoOpProvider.java

@@ -2,7 +2,7 @@
 
 import lombok.Getter;
 
-public class NoOpProvider<T extends EvaluationContext> implements FeatureProvider {
+public class NoOpProvider implements FeatureProvider {
     @Getter
     private final String name = "No-op Provider";
 

lib/src/test/java/javasdk/HookSpecTests.java

@@ -165,7 +165,7 @@ void emptyApiHooks() {
         doThrow(RuntimeException.class).when(h).finallyAfter(any(), any());
 
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.setProvider(new NoOpProvider<>());
+        api.setProvider(new NoOpProvider());
         Client c= api.getClient();
 
         assertThrows(RuntimeException.class, () -> c.getBooleanValue("key", false, null, FlagEvaluationOptions.builder().hook(h).build()));
@@ -292,7 +292,7 @@ void finallyAfter(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints)
     @Specification(spec="hooks", number="6.1", text="HookHints MUST passed between each hook.")
     @Test void hook_hints() {
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.setProvider(new NoOpProvider<>());
+        api.setProvider(new NoOpProvider());
         Client client = api.getClient();
         Hook<Boolean> mutatingHook = new Hook<Boolean>() {
             @Override
@@ -359,7 +359,7 @@ void finallyAfter(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints)
         Hook hook = mock(Hook.class);
         doThrow(RuntimeException.class).when(hook).before(any(), any());
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.setProvider(new NoOpProvider<>());
+        api.setProvider(new NoOpProvider());
         Client client = api.getClient();
         client.getBooleanValue("key", false, new EvaluationContext(),
                 FlagEvaluationOptions.builder().hook(hook).build());
@@ -374,7 +374,7 @@ void finallyAfter(HookContext<Boolean> ctx, ImmutableMap<String, Object> hints)
         doThrow(RuntimeException.class).when(hook).before(any(), any());
 
         OpenFeatureAPI api = OpenFeatureAPI.getInstance();
-        api.setProvider(new NoOpProvider<>());
+        api.setProvider(new NoOpProvider());
         Client client = api.getClient();
 
         client.getBooleanValue("key", false, new EvaluationContext(),

lib/src/test/java/javasdk/NoOpProviderTest.java

@@ -0,0 +1,26 @@
+package javasdk;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class NoOpProviderTest {
+    @Test void bool() {
+        NoOpProvider p = new NoOpProvider();
+        ProviderEvaluation<Boolean> eval = p.getBooleanEvaluation("key", true, null, null);
+        assertEquals(true, eval.getValue());
+    }
+
+    @Test void str() {
+        NoOpProvider p = new NoOpProvider();
+
+        ProviderEvaluation<String> eval = p.getStringEvaluation("key", "works", null, null);
+        assertEquals("works", eval.getValue());
+    }
+
+    @Test void integer() {
+        NoOpProvider p = new NoOpProvider();
+        ProviderEvaluation<Integer> eval = p.getIntegerEvaluation("key", 4, null, null);
+        assertEquals(4, eval.getValue());
+    }
+}