fixup! feat: implemented support for tracking

Signed-off-by: Bernd Warmuth <[email protected]>

Author: Bernd Warmuth

src/main/java/dev/openfeature/sdk/FeatureProvider.java

@@ -1,6 +1,5 @@
 package dev.openfeature.sdk;
 
-import javax.annotation.Nullable;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -76,10 +75,10 @@ default ProviderState getState() {
      * Feature provider implementations can opt in for to support Tracking by implementing this method.
      *
      * @param eventName The name of the tracking event
-     * @param context           Evaluation context used in flag evaluation (Optional)
-     * @param details           Data pertinent to a particular tracking event (Optional)
+     * @param context   Evaluation context used in flag evaluation (Optional)
+     * @param details   Data pertinent to a particular tracking event (Optional)
      */
-    default void track(String eventName, @Nullable EvaluationContext context, @Nullable TrackingEventDetails details) {
+    default void track(String eventName, EvaluationContext context, TrackingEventDetails details) {
 
     }
 }

src/main/java/dev/openfeature/sdk/MutableTrackingEventDetails.java

@@ -16,19 +16,18 @@
 @ToString
 public class MutableTrackingEventDetails implements TrackingEventDetails {
 
-
     @Getter
-    private final float target;
+    private final Number value;
     @Delegate(excludes = MutableTrackingEventDetails.DelegateExclusions.class)
     private final MutableStructure structure;
 
     public MutableTrackingEventDetails() {
-        this.target = 0f;
+        this.value = 0f;
         this.structure = new MutableStructure();
     }
 
-    public MutableTrackingEventDetails(final float target) {
-        this.target = target;
+    public MutableTrackingEventDetails(final float value) {
+        this.value = value;
         this.structure = new MutableStructure();
     }
 

src/main/java/dev/openfeature/sdk/OpenFeatureClient.java

@@ -11,7 +11,6 @@
 import lombok.Getter;
 import lombok.extern.slf4j.Slf4j;
 
-import javax.annotation.Nullable;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -230,9 +229,7 @@ private static <T> void enrichDetailsWithErrorDefaults(T defaultValue, FlagEvalu
         details.setReason(Reason.ERROR.toString());
     }
 
-    private void invokeTrack(String trackingEventName,
-                             @Nullable EvaluationContext context,
-                             @Nullable TrackingEventDetails details) {
+    private void invokeTrack(String trackingEventName, EvaluationContext context, TrackingEventDetails details) {
         if ("".equals(trackingEventName)) {
             throw new IllegalArgumentException("trackingEventName cannot be empty");
         }

src/test/java/dev/openfeature/sdk/TrackingSpecTest.java

@@ -136,8 +136,8 @@ void noopProvider() {
             "fields, having keys of type `string`, and values of type `boolean | string | number | structure`.")
     @Test
     void eventDetails() {
-        assertEquals(0f, new MutableTrackingEventDetails().getTarget());
-        assertEquals(9.87f, new MutableTrackingEventDetails(9.87f).getTarget());
+        assertEquals(0f, new MutableTrackingEventDetails().getValue());
+        assertEquals(9.87f, new MutableTrackingEventDetails(9.87f).getValue());
         Map<String, Value> expectedMap = Maps.newHashMap();
         expectedMap.put("my-str", new Value("str"));
         expectedMap.put("my-num", new Value(1));