Skip to content

Commit c8a4172

Browse files
committed
try to run jmh bench
Signed-off-by: christian.lutnik <[email protected]>
1 parent 9a62234 commit c8a4172

File tree

4 files changed

+29
-29
lines changed

4 files changed

+29
-29
lines changed

.github/workflows/pullrequest.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ jobs:
5454
fail_ci_if_error: true # optional (default = false)
5555
verbose: true # optional (default = false)
5656

57-
- name: Run JMH benchmark
58-
run: mvn --activate-profiles benchmark jmh:benchmark
57+
- if: matrix.build.java == '17'
58+
name: Run JMH benchmark
59+
run: mvn --activate-profiles benchmark jmh:benchmark -rf json -rff output.json .*
5960
#run: |
6061
# 'mvn clean compile'
6162
# 'mvn jmh:benchmark -rf json -rff output.json .*'

src/test/java/dev/openfeature/sdk/benchmark/FlagEvaluationBenchmark.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,19 @@
1010
import org.openjdk.jmh.annotations.Mode;
1111
import org.openjdk.jmh.annotations.Warmup;
1212

13-
1413
@BenchmarkMode(Mode.Throughput)
1514
@Warmup(time = 1, timeUnit = TimeUnit.SECONDS, iterations = 1)
16-
//@Warmup(time = 1, timeUnit = TimeUnit.SECONDS, iterations = 2)
15+
// @Warmup(time = 1, timeUnit = TimeUnit.SECONDS, iterations = 2)
1716
@Measurement(time = 5, timeUnit = TimeUnit.SECONDS, iterations = 1)
18-
//@Measurement(time = 5, timeUnit = TimeUnit.SECONDS, iterations = 4)
17+
// @Measurement(time = 5, timeUnit = TimeUnit.SECONDS, iterations = 4)
1918
@Fork(1)
2019
public class FlagEvaluationBenchmark {
2120

2221
@Benchmark
2322
public String flagEvaluations(FlagEvaluationState state) {
24-
return state.client.getStringDetails(FlagEvaluationState.FLAG_KEY, "default").getValue();
23+
return state.client
24+
.getStringDetails(FlagEvaluationState.FLAG_KEY, "default")
25+
.getValue();
2526
}
2627

2728
@Benchmark

src/test/java/dev/openfeature/sdk/benchmark/state/FlagEvaluationState.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
import dev.openfeature.sdk.OpenFeatureAPI;
66
import dev.openfeature.sdk.providers.memory.Flag;
77
import dev.openfeature.sdk.providers.memory.InMemoryProvider;
8-
import org.openjdk.jmh.annotations.*;
98
import java.util.Map;
9+
import org.openjdk.jmh.annotations.*;
1010

1111
@State(Scope.Benchmark)
1212
public class FlagEvaluationState {
@@ -18,17 +18,16 @@ public class FlagEvaluationState {
1818

1919
@Setup(Level.Trial)
2020
public void setup() {
21-
provider = new InMemoryProvider(
22-
Map.of(
23-
FLAG_KEY,
24-
Flag.builder()
25-
.variant("a", "a-value")
26-
.variant("b", "b-value")
27-
.defaultVariant("b")
28-
.flagMetadata(ImmutableMetadata.builder().addString("meta", "data").build())
29-
.build()
30-
)
31-
);
21+
provider = new InMemoryProvider(Map.of(
22+
FLAG_KEY,
23+
Flag.builder()
24+
.variant("a", "a-value")
25+
.variant("b", "b-value")
26+
.defaultVariant("b")
27+
.flagMetadata(ImmutableMetadata.builder()
28+
.addString("meta", "data")
29+
.build())
30+
.build()));
3231
OpenFeatureAPI.getInstance().setProviderAndWait(DOMAIN, provider);
3332
client = OpenFeatureAPI.getInstance().getClient(DOMAIN);
3433
}

src/test/java/dev/openfeature/sdk/benchmark/state/HooksState.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,16 @@ public class HooksState {
2424

2525
@Setup(Level.Trial)
2626
public void setup() {
27-
provider = new InMemoryProvider(
28-
Map.of(
29-
FLAG_KEY,
30-
Flag.builder()
31-
.variant("a", "a-value")
32-
.variant("b", "b-value")
33-
.defaultVariant("b")
34-
.flagMetadata(ImmutableMetadata.builder().addString("meta", "data").build())
35-
.build()
36-
)
37-
);
27+
provider = new InMemoryProvider(Map.of(
28+
FLAG_KEY,
29+
Flag.builder()
30+
.variant("a", "a-value")
31+
.variant("b", "b-value")
32+
.defaultVariant("b")
33+
.flagMetadata(ImmutableMetadata.builder()
34+
.addString("meta", "data")
35+
.build())
36+
.build()));
3837
OpenFeatureAPI.getInstance().setProviderAndWait(DOMAIN, provider);
3938
client = OpenFeatureAPI.getInstance().getClient(DOMAIN);
4039
client.addHooks(new StringHook() {}, new Hook() {});

0 commit comments

Comments
 (0)