Skip to content

Commit ce92510

Browse files
committed
use concurrent data structure for hooks
Signed-off-by: christian.lutnik <[email protected]>
1 parent b7816ae commit ce92510

File tree

1 file changed

+0
-30
lines changed

1 file changed

+0
-30
lines changed

src/test/java/dev/openfeature/sdk/LockingSingeltonTest.java

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ void beforeEach() {
3636
OpenFeatureAPI.lock = apiLock;
3737

3838
clientHooksLock = setupLock(clientHooksLock, mockInnerReadLock(), mockInnerWriteLock());
39-
client.hooksLock = clientHooksLock;
4039
}
4140

4241
@Nested
@@ -134,28 +133,6 @@ void onProviderErrorProviderReadyShouldApiWriteLockAndUnlock() {
134133
}
135134
}
136135

137-
@Test
138-
void addHooksShouldWriteLockAndUnlock() {
139-
client.addHooks(new Hook() {});
140-
verify(clientHooksLock.writeLock()).lock();
141-
verify(clientHooksLock.writeLock()).unlock();
142-
143-
api.addHooks(new Hook() {});
144-
verify(apiLock.writeLock()).lock();
145-
verify(apiLock.writeLock()).unlock();
146-
}
147-
148-
@Test
149-
void getHooksShouldReadLockAndUnlock() {
150-
client.getHooks();
151-
verify(clientHooksLock.readLock()).lock();
152-
verify(clientHooksLock.readLock()).unlock();
153-
154-
api.getHooks();
155-
verify(apiLock.readLock()).lock();
156-
verify(apiLock.readLock()).unlock();
157-
}
158-
159136
@Test
160137
void setTransactionalContextPropagatorShouldWriteLockAndUnlock() {
161138
api.setTransactionContextPropagator(new NoOpTransactionContextPropagator());
@@ -170,13 +147,6 @@ void getTransactionalContextPropagatorShouldReadLockAndUnlock() {
170147
verify(apiLock.readLock()).unlock();
171148
}
172149

173-
@Test
174-
void clearHooksShouldWriteLockAndUnlock() {
175-
api.clearHooks();
176-
verify(apiLock.writeLock()).lock();
177-
verify(apiLock.writeLock()).unlock();
178-
}
179-
180150
private static ReentrantReadWriteLock.ReadLock mockInnerReadLock() {
181151
ReentrantReadWriteLock.ReadLock readLockMock = mock(ReentrantReadWriteLock.ReadLock.class);
182152
doNothing().when(readLockMock).lock();

0 commit comments

Comments
 (0)