reduce visibility of emit methods, add error code to ProviderEventDetails

Signed-off-by: christian.lutnik <[email protected]>

Author: chrfwow

src/main/java/dev/openfeature/sdk/EventProvider.java

@@ -53,7 +53,7 @@ void detach() {
      * @param event   The event type
      * @param details The details of the event
      */
-    public void emit(ProviderEvent event, ProviderEventDetails details) {
+    protected void emit(ProviderEvent event, ProviderEventDetails details) {
         if (eventProviderListener != null) {
             eventProviderListener.onEmit(event, details);
         }
@@ -68,7 +68,7 @@ public void emit(ProviderEvent event, ProviderEventDetails details) {
      *
      * @param details The details of the event
      */
-    public void emitProviderReady(ProviderEventDetails details) {
+    protected void emitProviderReady(ProviderEventDetails details) {
         emit(ProviderEvent.PROVIDER_READY, details);
     }
 
@@ -79,7 +79,7 @@ public void emitProviderReady(ProviderEventDetails details) {
      *
      * @param details The details of the event
      */
-    public void emitProviderConfigurationChanged(ProviderEventDetails details) {
+    protected void emitProviderConfigurationChanged(ProviderEventDetails details) {
         emit(ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, details);
     }
 
@@ -89,7 +89,7 @@ public void emitProviderConfigurationChanged(ProviderEventDetails details) {
      *
      * @param details The details of the event
      */
-    public void emitProviderStale(ProviderEventDetails details) {
+    protected void emitProviderStale(ProviderEventDetails details) {
         emit(ProviderEvent.PROVIDER_STALE, details);
     }
 
@@ -99,7 +99,7 @@ public void emitProviderStale(ProviderEventDetails details) {
      *
      * @param details The details of the event
      */
-    public void emitProviderError(ProviderEventDetails details) {
+    protected void emitProviderError(ProviderEventDetails details) {
         emit(ProviderEvent.PROVIDER_ERROR, details);
     }
 

src/main/java/dev/openfeature/sdk/ProviderEventDetails.java

@@ -13,4 +13,5 @@ public class ProviderEventDetails {
     private List<String> flagsChanged;
     private String message;
     private ImmutableMetadata eventMetadata;
+    private ErrorCode errorCode;
 }

src/main/java/dev/openfeature/sdk/StatefulFeatureProvider.java

@@ -81,7 +81,11 @@ public boolean equals(Object obj) {
     @Override
     public void onEmit(ProviderEvent event, ProviderEventDetails details) {
         if (ProviderEvent.PROVIDER_ERROR.equals(event)) {
-            state = ProviderState.ERROR;
+            if (details != null && details.getErrorCode() == ErrorCode.PROVIDER_FATAL) {
+                state = ProviderState.FATAL;
+            } else {
+                state = ProviderState.ERROR;
+            }
         } else if (ProviderEvent.PROVIDER_STALE.equals(event)) {
             state = ProviderState.STALE;
         } else if (ProviderEvent.PROVIDER_READY.equals(event)) {

src/test/java/dev/openfeature/sdk/StatefulFeatureProviderTest.java

@@ -129,10 +129,24 @@ void shouldSetTheStateToStaleWhenAStaleEventIsEmitted() {
     @Test
     void shouldSetTheStateToErrorWhenAnErrorEventIsEmitted() {
         assertThat(wrapper.getState()).isEqualTo(ProviderState.NOT_READY);
-        wrapper.onEmit(ProviderEvent.PROVIDER_ERROR, null);
+        wrapper.onEmit(
+                ProviderEvent.PROVIDER_ERROR,
+                ProviderEventDetails.builder().errorCode(ErrorCode.GENERAL).build()
+        );
         assertThat(wrapper.getState()).isEqualTo(ProviderState.ERROR);
     }
 
+    @Specification(number = "5.3.5", text = "If the provider emits an event, the value of the client's provider status MUST be updated accordingly.")
+    @Test
+    void shouldSetTheStateToFatalWhenAFatalErrorEventIsEmitted() {
+        assertThat(wrapper.getState()).isEqualTo(ProviderState.NOT_READY);
+        wrapper.onEmit(
+                ProviderEvent.PROVIDER_ERROR,
+                ProviderEventDetails.builder().errorCode(ErrorCode.PROVIDER_FATAL).build()
+        );
+        assertThat(wrapper.getState()).isEqualTo(ProviderState.FATAL);
+    }
+
     static class TestDelegate extends EventProvider {
         private final AtomicInteger initCalled = new AtomicInteger();
         private final AtomicInteger shutdownCalled = new AtomicInteger();

src/test/java/dev/openfeature/sdk/providers/memory/InMemoryProviderTest.java

@@ -45,12 +45,6 @@ void beforeEach() {
                 .build());
     }
 
-    @SneakyThrows
-    @Test
-    void eventsTest() {
-        verify(provider, times(2)).emitProviderConfigurationChanged(any());
-    }
-
     @Test
     void getBooleanEvaluation() {
         assertTrue(client.getBooleanValue("boolean-flag", false));