chore: update cuke submodule, tests (#231)

* chore: update cuke submodule, tests

Signed-off-by: Todd Baert <[email protected]>

* fixup: add note about flagd caching

Signed-off-by: Todd Baert <[email protected]>

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

pom.xml

@@ -519,6 +519,7 @@
                   <goal>exec</goal>
                 </goals>
                 <configuration>
+                  <!-- copy the feature spec we want to test into resources so them can be easily loaded -->
                   <!-- run: cp test-harness/features/evaluation.feature src/test/resources/features/ -->
                   <executable>cp</executable>
                   <arguments>

src/test/java/dev/openfeature/sdk/integration/StepDefinitions.java

@@ -6,13 +6,13 @@
 import dev.openfeature.contrib.providers.flagd.FlagdProvider;
 import dev.openfeature.sdk.Client;
 import dev.openfeature.sdk.FlagEvaluationDetails;
-import dev.openfeature.sdk.MutableStructure;
 import dev.openfeature.sdk.MutableContext;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import dev.openfeature.sdk.Reason;
 import dev.openfeature.sdk.Structure;
 import dev.openfeature.sdk.Value;
 import io.cucumber.java.BeforeAll;
+import io.cucumber.java.en.Given;
 import io.cucumber.java.en.Then;
 import io.cucumber.java.en.When;
 
@@ -44,7 +44,9 @@ public class StepDefinitions {
     private FlagEvaluationDetails<Integer> typeErrorDetails;
 
     @BeforeAll()
+    @Given("an openfeature client is registered with cache disabled")
     public static void setup() {
+        // TODO: when the FlagdProvider is updated to support caching, we might need to disable it here for this test to work as expected.
         FlagdProvider provider = new FlagdProvider();
         provider.setDeadline(3000); // set a generous deadline, to prevent timeouts in actions
         OpenFeatureAPI.getInstance().setProvider(provider);
@@ -249,7 +251,7 @@ public void a_non_existent_string_flag_with_key_is_evaluated_with_details_and_a_
         notFoundDetails = client.getStringDetails(notFoundFlagKey, notFoundDefaultValue);
     }
 
-    @Then("then the default string value should be returned")
+    @Then("the default string value should be returned")
     public void then_the_default_string_value_should_be_returned() {
         assertEquals(notFoundDefaultValue, notFoundDetails.getValue());
     }
@@ -270,7 +272,7 @@ public void a_string_flag_with_key_is_evaluated_as_an_integer_with_details_and_a
         typeErrorDetails = client.getIntegerDetails(typeErrorFlagKey, typeErrorDefaultValue);
     }
 
-    @Then("then the default integer value should be returned")
+    @Then("the default integer value should be returned")
     public void then_the_default_integer_value_should_be_returned() {
         assertEquals(typeErrorDefaultValue, typeErrorDetails.getValue());
     }