Skip to content

Commit 0733ac7

Browse files
committed
fixup: typechecks
Signed-off-by: Todd Baert <[email protected]>
1 parent 477c601 commit 0733ac7

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

libs/hooks/debounce/src/lib/debounce-hook.spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ describe('DebounceHook', () => {
99
jest.resetAllMocks();
1010
});
1111

12-
const innerHook: BaseHook<string, void, void> = {
12+
const innerHook: BaseHook<string, Record<string, unknown>, void, void> = {
1313
before: jest.fn(),
1414
after: jest.fn(),
1515
error: jest.fn(),
@@ -69,7 +69,7 @@ describe('DebounceHook', () => {
6969
});
7070

7171
it('stages should be cached independently', () => {
72-
const innerHook: BaseHook<boolean, void, void> = {
72+
const innerHook: BaseHook<boolean, Record<string, unknown>, void, void> = {
7373
before: jest.fn(),
7474
after: jest.fn(),
7575
};
@@ -100,7 +100,7 @@ describe('DebounceHook', () => {
100100
});
101101

102102
it('maxCacheItems should limit size', () => {
103-
const innerHook: BaseHook<string, void, void> = {
103+
const innerHook: BaseHook<string, Record<string, unknown>, void, void> = {
104104
before: jest.fn(),
105105
};
106106

@@ -118,7 +118,7 @@ describe('DebounceHook', () => {
118118
});
119119

120120
it('should rerun inner hook only after debounce time', async () => {
121-
const innerHook: BaseHook<string, void, void> = {
121+
const innerHook: BaseHook<string, Record<string, unknown>, void, void> = {
122122
before: jest.fn(),
123123
};
124124

@@ -142,7 +142,7 @@ describe('DebounceHook', () => {
142142
});
143143

144144
it('use custom supplier', () => {
145-
const innerHook: BaseHook<number, void, void> = {
145+
const innerHook: BaseHook<number, Record<string, unknown>, void, void> = {
146146
before: jest.fn(),
147147
after: jest.fn(),
148148
error: jest.fn(),
@@ -177,7 +177,7 @@ describe('DebounceHook', () => {
177177
timesCalled: 1, // should be called once since we cached the error
178178
},
179179
])('should cache errors if cacheErrors set', ({ cacheErrors, timesCalled }) => {
180-
const innerErrorHook: BaseHook<string[], void, void> = {
180+
const innerErrorHook: BaseHook<string[], Record<string, unknown>, void, void> = {
181181
before: jest.fn(() => {
182182
// throw an error
183183
throw new Error('fake!');

libs/hooks/debounce/src/lib/debounce-hook.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,10 @@ export class DebounceHook<T extends FlagValue = FlagValue> implements BaseHook {
8787
private readonly cacheKeySupplier: Options['cacheKeySupplier'];
8888

8989
public constructor(
90+
// this is a superset of web and server hook forms; validated by the test suite
9091
private readonly innerHook: BaseHook<
91-
T,
92+
FlagValue,
93+
Record<string, unknown>,
9294
Promise<EvaluationContext | void> | EvaluationContext | void,
9395
Promise<void> | void
9496
>,

0 commit comments

Comments
 (0)