Skip to content

Commit 094cb19

Browse files
committed
fixup: revert generalization attempt
Signed-off-by: Simon Schrottner <[email protected]>
1 parent 10df4a4 commit 094cb19

File tree

18 files changed

+36
-30
lines changed

18 files changed

+36
-30
lines changed

libs/providers/flagd-web/schemas

libs/providers/flagd-web/src/e2e/jest.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ export default {
44
'^.+\\.[tj]s$': ['ts-jest', { tsconfig: './tsconfig.lib.json' }],
55
},
66
moduleNameMapper: {
7+
'@openfeature/flagd-core': ['<rootDir>/../../../../shared/flagd-core/src'],
78
'^(.*)\\.js$': ['$1.js', '$1.ts', '$1'],
89
},
910
testEnvironment: 'node',

libs/providers/flagd-web/src/e2e/tests/provider.spec.ts

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
import assert from 'assert';
2-
import { OpenFeature } from '@openfeature/web-sdk';
2+
import { Client, OpenFeature } from '@openfeature/web-sdk';
33
import { GenericContainer, StartedTestContainer } from 'testcontainers';
44
import { FlagdWebProvider } from '../../lib/flagd-web-provider';
55
import { autoBindSteps, loadFeature } from 'jest-cucumber';
6-
import { flagStepDefinitions, GHERKIN_EVALUATION_FEATURE, IMAGE_VERSION } from '@openfeature/flagd-core';
6+
import {
7+
E2E_CLIENT_NAME,
8+
flagStepDefinitions,
9+
GHERKIN_EVALUATION_FEATURE,
10+
IMAGE_VERSION,
11+
} from '@openfeature/flagd-core';
712

813
// register the flagd provider before the tests.
914
async function setup() {
@@ -16,6 +21,7 @@ async function setup() {
1621
.start();
1722
containers.push(stable);
1823
OpenFeature.setProvider(
24+
E2E_CLIENT_NAME,
1925
new FlagdWebProvider({
2026
host: stable.getHost(),
2127
port: stable.getMappedPort(8013),
@@ -24,9 +30,9 @@ async function setup() {
2430
}),
2531
);
2632
assert(
27-
OpenFeature.providerMetadata.name === FlagdWebProvider.name,
33+
OpenFeature.getProviderMetadata(E2E_CLIENT_NAME).name === E2E_CLIENT_NAME,
2834
new Error(
29-
`Expected ${FlagdWebProvider.name} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`,
35+
`Expected ${E2E_CLIENT_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`,
3036
),
3137
);
3238
console.log('flagd provider configured!');
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
{
22
"extends": "../../tsconfig.json",
33
"compilerOptions": {
4-
"lib": ["ES2015", "DOM"],
4+
"lib": ["ES2022", "DOM"],
55
"outDir": "../../../dist/out-tsc",
66
"declaration": true,
77
"types": ["jest"],
88
"allowSyntheticDefaultImports": true,
9-
"allowJs" :true
9+
"allowJs" :true,
10+
"resolveJsonModule": true
1011
}
1112
}
File renamed without changes.

libs/shared/flagd-core/src/e2e/step-definitions/flag.ts renamed to libs/providers/flagd/src/e2e/step-definitions/flag.ts

File renamed without changes.

libs/shared/flagd-core/src/e2e/step-definitions/flagd-json-evaluator.ts renamed to libs/providers/flagd/src/e2e/step-definitions/flagd-json-evaluator.ts

File renamed without changes.

libs/shared/flagd-core/src/e2e/step-definitions/index.ts renamed to libs/providers/flagd/src/e2e/step-definitions/index.ts

File renamed without changes.

0 commit comments

Comments
 (0)