Skip to content

Commit 273c6ff

Browse files
gioddiggitoddbaert
gioddiggi
authored and
toddbaert
committed
fix: address linting issues
Signed-off-by: Giovanni De Giorgio <[email protected]>
1 parent 331c73f commit 273c6ff

File tree

2 files changed

+41
-51
lines changed

2 files changed

+41
-51
lines changed

‎libs/providers/aws-ssm/src/lib/aws-ssm-provider.spec.ts‎

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import type { SSMClientConfig } from '@aws-sdk/client-ssm';
22
import { AwsSsmProvider } from './aws-ssm-provider';
33
import { ErrorCode, StandardResolutionReasons } from '@openfeature/core';
44

5-
describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
6-
5+
describe('aws-ssm-provider.ts - AwsSsmProvider', () => {
76
let provider: AwsSsmProvider;
87
let getBooleanValueSpy: jest.SpyInstance;
98
let getStringValueSpy: jest.SpyInstance;
@@ -34,9 +33,8 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
3433
getObjectValueSpy = jest.spyOn(provider.service, 'getObjectValue');
3534
});
3635

37-
describe("resolveBooleanEvaluation", () => {
38-
39-
it("should return cached value when flag is cached", async () => {
36+
describe('resolveBooleanEvaluation', () => {
37+
it('should return cached value when flag is cached', async () => {
4038
provider.cache.set('test', {
4139
value: true,
4240
reason: StandardResolutionReasons.STATIC,
@@ -50,7 +48,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
5048
});
5149
});
5250

53-
it("should return default value when getBooleanValue rejects", async () => {
51+
it('should return default value when getBooleanValue rejects', async () => {
5452
getBooleanValueSpy.mockRejectedValue(new Error());
5553

5654
const result = await provider.resolveBooleanEvaluation('test-error', false, {});
@@ -63,7 +61,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
6361
});
6462
});
6563

66-
it("should resolve with expected value when getBooleanValue resolves", async () => {
64+
it('should resolve with expected value when getBooleanValue resolves', async () => {
6765
getBooleanValueSpy.mockResolvedValue({
6866
value: true,
6967
reason: StandardResolutionReasons.STATIC,
@@ -78,9 +76,8 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
7876
});
7977
});
8078

81-
describe("resolveStringEvaluation", () => {
82-
83-
it("should return cached value when flag is cached", async () => {
79+
describe('resolveStringEvaluation', () => {
80+
it('should return cached value when flag is cached', async () => {
8481
provider.cache.set('test-string', {
8582
value: 'somestring',
8683
reason: StandardResolutionReasons.STATIC,
@@ -94,7 +91,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
9491
});
9592
});
9693

97-
it("should return default value when getStringValue rejects", async () => {
94+
it('should return default value when getStringValue rejects', async () => {
9895
getStringValueSpy.mockRejectedValue(new Error());
9996

10097
const result = await provider.resolveStringEvaluation('test-string-error', 'default', {});
@@ -107,7 +104,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
107104
});
108105
});
109106

110-
it("should resolve with expected value when getStringValue resolves", async () => {
107+
it('should resolve with expected value when getStringValue resolves', async () => {
111108
getStringValueSpy.mockResolvedValue({
112109
value: 'somestring',
113110
reason: StandardResolutionReasons.STATIC,
@@ -122,9 +119,8 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
122119
});
123120
});
124121

125-
describe("resolveNumberEvaluation", () => {
126-
127-
it("should return cached value when flag is cached", async () => {
122+
describe('resolveNumberEvaluation', () => {
123+
it('should return cached value when flag is cached', async () => {
128124
provider.cache.set('test-number', {
129125
value: 489,
130126
reason: StandardResolutionReasons.STATIC,
@@ -138,7 +134,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
138134
});
139135
});
140136

141-
it("should return default value when getNumberValue rejects", async () => {
137+
it('should return default value when getNumberValue rejects', async () => {
142138
getNumberValueSpy.mockRejectedValue(new Error());
143139

144140
const result = await provider.resolveNumberEvaluation('test-number-error', -1, {});
@@ -151,7 +147,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
151147
});
152148
});
153149

154-
it("should resolve with expected value when getNumberValue resolves", async () => {
150+
it('should resolve with expected value when getNumberValue resolves', async () => {
155151
getNumberValueSpy.mockResolvedValue({
156152
value: 489,
157153
reason: StandardResolutionReasons.STATIC,
@@ -166,9 +162,8 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
166162
});
167163
});
168164

169-
describe("resolveObjectEvaluation", () => {
170-
171-
it("should return cached value when flag is cached", async () => {
165+
describe('resolveObjectEvaluation', () => {
166+
it('should return cached value when flag is cached', async () => {
172167
provider.cache.set('test-object', {
173168
value: { default: false },
174169
reason: StandardResolutionReasons.STATIC,
@@ -182,7 +177,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
182177
});
183178
});
184179

185-
it("should return default value when getObjectValue rejects", async () => {
180+
it('should return default value when getObjectValue rejects', async () => {
186181
getObjectValueSpy.mockRejectedValue(new Error());
187182

188183
const result = await provider.resolveObjectEvaluation('test-object-error', { default: true }, {});
@@ -195,7 +190,7 @@ describe("aws-ssm-provider.ts - AwsSsmProvider", () => {
195190
});
196191
});
197192

198-
it("should resolve with expected value when getObjectValue resolves", async () => {
193+
it('should resolve with expected value when getObjectValue resolves', async () => {
199194
getObjectValueSpy.mockResolvedValue({
200195
value: { default: true },
201196
reason: StandardResolutionReasons.STATIC,

‎libs/providers/aws-ssm/src/lib/ssm-service.spec.ts‎

Lines changed: 24 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import { ParseError, StandardResolutionReasons, TypeMismatchError } from '@openfeature/core';
22
import { SSMService } from './ssm-service';
33

4-
describe("ssm-service.ts - SSMService", () => {
5-
4+
describe('ssm-service.ts - SSMService', () => {
65
let service: SSMService;
76
let getValueFromSSMSpy: jest.SpyInstance;
87

@@ -11,13 +10,12 @@ describe("ssm-service.ts - SSMService", () => {
1110
getValueFromSSMSpy = jest.spyOn(SSMService.prototype, '_getValueFromSSM');
1211
});
1312

14-
describe("getBooleanValue", () => {
15-
13+
describe('getBooleanValue', () => {
1614
it("should return true when _getValueFromSSM returns 'true'", async () => {
1715
getValueFromSSMSpy.mockResolvedValue({ val: 'true', metadata: { httpStatusCode: 200 } });
18-
16+
1917
const result = await service.getBooleanValue('test');
20-
18+
2119
expect(result).toEqual({
2220
value: true,
2321
reason: StandardResolutionReasons.STATIC,
@@ -27,30 +25,29 @@ describe("ssm-service.ts - SSMService", () => {
2725

2826
it("should return false when _getValueFromSSM returns 'false'", async () => {
2927
getValueFromSSMSpy.mockResolvedValue({ val: 'false', metadata: { httpStatusCode: 200 } });
30-
28+
3129
const result = await service.getBooleanValue('test');
32-
30+
3331
expect(result).toEqual({
3432
value: false,
3533
reason: StandardResolutionReasons.STATIC,
3634
flagMetadata: { httpStatusCode: 200 },
3735
});
3836
});
3937

40-
it("should throw TypeMismatchError when _getValueFromSSM returns invalid boolean", async () => {
38+
it('should throw TypeMismatchError when _getValueFromSSM returns invalid boolean', async () => {
4139
getValueFromSSMSpy.mockResolvedValue({ val: 'invalid boolean', metadata: { httpStatusCode: 400 } });
42-
40+
4341
await expect(service.getBooleanValue('test')).rejects.toThrow(TypeMismatchError);
4442
});
4543
});
4644

47-
describe("getStringValue", () => {
48-
49-
it("should return the string value when _getValueFromSSM returns valid value", async () => {
45+
describe('getStringValue', () => {
46+
it('should return the string value when _getValueFromSSM returns valid value', async () => {
5047
getValueFromSSMSpy.mockResolvedValue({ val: 'example', metadata: { httpStatusCode: 200 } });
51-
48+
5249
const result = await service.getStringValue('example');
53-
50+
5451
expect(result).toEqual({
5552
value: 'example',
5653
reason: StandardResolutionReasons.STATIC,
@@ -59,44 +56,42 @@ describe("ssm-service.ts - SSMService", () => {
5956
});
6057
});
6158

62-
describe("getNumberValue", () => {
63-
64-
it("should return the number value when _getValueFromSSM returns valid number", async () => {
59+
describe('getNumberValue', () => {
60+
it('should return the number value when _getValueFromSSM returns valid number', async () => {
6561
getValueFromSSMSpy.mockResolvedValue({ val: '1478', metadata: { httpStatusCode: 200 } });
66-
62+
6763
const result = await service.getNumberValue('test');
68-
64+
6965
expect(result).toEqual({
7066
value: 1478,
7167
reason: StandardResolutionReasons.STATIC,
7268
flagMetadata: { httpStatusCode: 200 },
7369
});
7470
});
7571

76-
it("should throw TypeMismatchError when _getValueFromSSM returns invalid number", async () => {
72+
it('should throw TypeMismatchError when _getValueFromSSM returns invalid number', async () => {
7773
getValueFromSSMSpy.mockResolvedValue({ val: 'invalid number', metadata: { httpStatusCode: 400 } });
78-
74+
7975
await expect(service.getNumberValue('test')).rejects.toThrow(TypeMismatchError);
8076
});
8177
});
8278

83-
describe("getObjectValue", () => {
84-
85-
it("should return the parsed object when _getValueFromSSM returns valid JSON", async () => {
79+
describe('getObjectValue', () => {
80+
it('should return the parsed object when _getValueFromSSM returns valid JSON', async () => {
8681
getValueFromSSMSpy.mockResolvedValue({ val: JSON.stringify({ test: true }), metadata: { httpStatusCode: 400 } });
87-
82+
8883
const result = await service.getObjectValue('test');
89-
84+
9085
expect(result).toEqual({
9186
value: { test: true },
9287
reason: StandardResolutionReasons.STATIC,
9388
flagMetadata: { httpStatusCode: 400 },
9489
});
9590
});
9691

97-
it("should throw ParseError when _getValueFromSSM returns invalid JSON", async () => {
92+
it('should throw ParseError when _getValueFromSSM returns invalid JSON', async () => {
9893
getValueFromSSMSpy.mockResolvedValue({ val: 'invalid object', metadata: { httpStatusCode: 400 } });
99-
94+
10095
await expect(service.getObjectValue('test')).rejects.toThrow(ParseError);
10196
});
10297
});

0 commit comments

Comments
 (0)