Skip to content

Commit 4b62af6

Browse files
committed
fix: resolve comments from gemini
Signed-off-by: JK Gunnink <[email protected]>
1 parent b129a0a commit 4b62af6

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

libs/providers/rocketflag/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ $ npm install @openfeature/rocketflag-provider
88

99
## Building
1010

11-
Run `nx package providers-rocketflag` to build the library.
11+
Run `npx nx run RocketFlag:package` to build the library.
1212

1313
## Running unit tests
1414

15-
Run `nx test providers-rocketflag` to execute the unit tests via [Jest](https://jestjs.io).
15+
Run `npx nx run RocketFlag:test` to execute the unit tests via [Jest](https://jestjs.io) from the root of the repo.

libs/providers/rocketflag/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@openfeature/rocketflag-provider",
3-
"version": "0.0.1",
3+
"version": "0.1.0",
44
"dependencies": {
55
"tslib": "^2.3.0"
66
},

libs/providers/rocketflag/project.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "RocketFlag",
33
"$schema": "../node_modules/nx/schemas/project-schema.json",
4-
"sourceRoot": "providers/src",
4+
"sourceRoot": "libs/providers/src",
55
"projectType": "library",
66
"release": {
77
"version": {

libs/providers/rocketflag/src/lib/rocketflag-provider.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ export function createRocketFlagProvider(client: RocketFlagClient): Provider & E
8282
runsOn: 'client' as const,
8383
hooks: [],
8484

85-
initialize: async (): Promise<void> => {
85+
initialize: async (_context: EvaluationContext, initLogger?: Logger): Promise<void> => {
86+
logger = initLogger;
8687
logger?.debug('Initialising RocketFlagProvider...');
8788
},
8889

tsconfig.base.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@openfeature/ofrep-core": ["libs/shared/ofrep-core/src/index.ts"],
3939
"@openfeature/ofrep-provider": ["libs/providers/ofrep/src/index.ts"],
4040
"@openfeature/ofrep-web-provider": ["libs/providers/ofrep-web/src/index.ts"],
41-
"@openfeature/rocketflag-provider": ["providers/src/index.ts"],
41+
"@openfeature/rocketflag-provider": ["libs/providers/src/index.ts"],
4242
"@openfeature/unleash-web-provider": ["libs/providers/unleash-web/src/index.ts"]
4343
}
4444
},

0 commit comments

Comments
 (0)