Merge branch 'main' into release-please--branches--main--components--launchdarkly-client-provider

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

.release-please-manifest.json

@@ -6,7 +6,7 @@
   "libs/providers/env-var": "0.3.1",
   "libs/providers/config-cat": "0.7.2",
   "libs/providers/launchdarkly-client": "0.3.1",
-  "libs/providers/go-feature-flag-web": "0.2.2",
+  "libs/providers/go-feature-flag-web": "0.2.3",
   "libs/shared/flagd-core": "0.2.5",
   "libs/shared/ofrep-core": "0.2.0",
   "libs/providers/ofrep": "0.2.0",

libs/providers/go-feature-flag-web/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.2.3](https://github.com/open-feature/js-sdk-contrib/compare/go-feature-flag-web-provider-v0.2.2...go-feature-flag-web-provider-v0.2.3) (2024-12-13)
+
+
+### 🐛 Bug Fixes
+
+* **go-feature-flag-web:** avoid infinite loop in waitWebsocketFinalSt… ([#1104](https://github.com/open-feature/js-sdk-contrib/issues/1104)) ([2cc7483](https://github.com/open-feature/js-sdk-contrib/commit/2cc7483ea0f8d178d5abfacfdce804db83704ba7))
+
 ## [0.2.2](https://github.com/open-feature/js-sdk-contrib/compare/go-feature-flag-web-provider-v0.2.1...go-feature-flag-web-provider-v0.2.2) (2024-12-03)
 
 

libs/providers/go-feature-flag-web/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@openfeature/go-feature-flag-web-provider",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "scripts": {
     "publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
     "current-version": "echo $npm_package_version"

libs/providers/go-feature-flag-web/package.json

@@ -80,6 +80,17 @@ describe('LaunchDarklyClientProvider', () => {
       expect(initialize).toHaveBeenCalledTimes(1);
       /* when not set in open feauture LD sdk initialize should be called with the anonymous context*/
       expect(initialize).toHaveBeenCalledWith(envKey, { anonymous: true }, { logger });
+      expect(ldClientMock.waitForInitialization).toHaveBeenCalledWith(undefined);
+    });
+
+    it('should call Ld waitForInitialization with correct arguments', async () => {
+      const provider = new LaunchDarklyClientProvider(envKey, { logger, initializationTimeout: 5 });
+      await provider.initialize();
+      expect(initialize).toHaveBeenCalledTimes(1);
+      /* when not set in open feauture LD sdk initialize should be called with the anonymous context*/
+      expect(initialize).toHaveBeenCalledWith(envKey, { anonymous: true }, { logger });
+      expect(ldClientMock.waitForInitialization).toHaveBeenCalledTimes(1);
+      expect(ldClientMock.waitForInitialization).toHaveBeenCalledWith(5);
     });
 
     it('should set the status to READY if initialization succeeds', async () => {

libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.spec.ts

@@ -42,6 +42,7 @@ export class LaunchDarklyClientProvider implements Provider {
 
   private readonly ldOptions: LDOptions | undefined;
   private readonly logger: Logger;
+  private readonly initializationTimeout?: number;
   private _client?: LDClient;
 
   public events = new OpenFeatureEventEmitter();
@@ -62,13 +63,14 @@ export class LaunchDarklyClientProvider implements Provider {
 
   constructor(
     private readonly envKey: string,
-    { logger, ...ldOptions }: LaunchDarklyProviderOptions,
+    { logger, initializationTimeout, ...ldOptions }: LaunchDarklyProviderOptions,
   ) {
     if (logger) {
       this.logger = logger;
     } else {
       this.logger = basicLogger({ level: 'info' });
     }
+    this.initializationTimeout = initializationTimeout;
     this.ldOptions = { ...ldOptions, logger: this.logger };
   }
 
@@ -92,7 +94,7 @@ export class LaunchDarklyClientProvider implements Provider {
     }
 
     try {
-      await this._client.waitForInitialization();
+      await this._client.waitForInitialization(this.initializationTimeout);
       this.status = ProviderStatus.READY;
     } catch {
       this.status = ProviderStatus.ERROR;

libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.ts

@@ -36,4 +36,16 @@ export interface LaunchDarklyProviderOptions extends LDOptions {
    * disclaimer: this logger instance will be used by the launch-darkly sdk
    */
   logger?: LDLogger | Logger;
+
+  /**
+   * Configures the amount of time, in seconds, to wait for initialization when
+   * connecting to the LaunchDarkly service.
+   *
+   * Using a large timeout is not recommended as network delays may cause your
+   * application to wait a long time before continuing execution.
+   *
+   * See the launchdarkly-js-client-sdk docs for more details:
+   * {@link https://launchdarkly.github.io/js-client-sdk/interfaces/LDClient.html#waitForInitialization}
+   */
+  initializationTimeout?: number;
 }