chore: move error methods above finally to show real call order

Signed-off-by: Lukas Reining <[email protected]>

Author: lukas-reining

libs/hooks/open-telemetry/src/lib/traces/tracing-hooks.ts

@@ -28,17 +28,17 @@ export class EventHook extends OpenTelemetryHook implements BaseHook {
     this.eventLogger = logs.getLogger(LIBRARY_NAME, LIBRARY_VERSION);
   }
 
-  finally(hookContext: Readonly<HookContext>, evaluationDetails: EvaluationDetails<FlagValue>) {
-    const { name, attributes } = this.toEvaluationEvent(hookContext, evaluationDetails);
-    this.eventLogger.emit({ eventName: name, attributes: attributes });
-  }
-
   error(_: HookContext, err: Error) {
     if (!this.excludeExceptions) {
       this.eventLogger.emit(this.toExceptionLogEvent(err));
     }
   }
 
+  finally(hookContext: Readonly<HookContext>, evaluationDetails: EvaluationDetails<FlagValue>) {
+    const { name, attributes } = this.toEvaluationEvent(hookContext, evaluationDetails);
+    this.eventLogger.emit({ eventName: name, attributes: attributes });
+  }
+
   /**
    * Converts an exception to an OpenTelemetry log event.
    * The event is compatible to https://opentelemetry.io/docs/specs/semconv/exceptions/exceptions-logs/
@@ -84,6 +84,12 @@ export class SpanEventHook extends OpenTelemetryHook implements BaseHook {
     super(options, logger);
   }
 
+  error(_: HookContext, err: Error) {
+    if (!this.excludeExceptions) {
+      trace.getActiveSpan()?.recordException(err);
+    }
+  }
+
   finally(hookContext: Readonly<HookContext>, evaluationDetails: EvaluationDetails<FlagValue>) {
     const currentTrace = trace.getActiveSpan();
     if (!currentTrace) {
@@ -94,12 +100,6 @@ export class SpanEventHook extends OpenTelemetryHook implements BaseHook {
 
     currentTrace.addEvent(name, attributes);
   }
-
-  error(_: HookContext, err: Error) {
-    if (!this.excludeExceptions) {
-      trace.getActiveSpan()?.recordException(err);
-    }
-  }
 }
 
 const tracer = trace.getTracer(LIBRARY_NAME, LIBRARY_VERSION);
@@ -124,6 +124,13 @@ export class SpanHook extends OpenTelemetryHook implements BaseHook {
     hookContext.hookData.set(HookContextSpanKey, evaluationSpan);
   }
 
+  error(hookContext: Readonly<HookContext<FlagValue, SpanAttributesTracingHookData>>, err: Error) {
+    if (!this.excludeExceptions) {
+      const currentSpan = hookContext.hookData.get(HookContextSpanKey) ?? trace.getActiveSpan();
+      currentSpan?.recordException(err);
+    }
+  }
+
   finally(
     hookContext: Readonly<HookContext<FlagValue, SpanAttributesTracingHookData>>,
     evaluationDetails: EvaluationDetails<FlagValue>,
@@ -138,11 +145,4 @@ export class SpanHook extends OpenTelemetryHook implements BaseHook {
     currentSpan.setAttributes(attributes);
     currentSpan.end();
   }
-
-  error(hookContext: Readonly<HookContext<FlagValue, SpanAttributesTracingHookData>>, err: Error) {
-    if (!this.excludeExceptions) {
-      const currentSpan = hookContext.hookData.get(HookContextSpanKey) ?? trace.getActiveSpan();
-      currentSpan?.recordException(err);
-    }
-  }
 }