Skip to content

Commit 7c8a41b

Browse files
committed
linting fixes applied
Signed-off-by: jarebudev <[email protected]>
1 parent 711a41a commit 7c8a41b

File tree

4 files changed

+48
-69
lines changed

4 files changed

+48
-69
lines changed

libs/providers/unleash-web/src/lib/test-logger.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ export default class TestLogger {
1919
}
2020

2121
info(...args: unknown[]): void {
22-
console.log(args)
22+
console.log(args);
2323
this.inMemoryLogger['info'].push(args.join(' '));
2424
}
2525

2626
debug(...args: unknown[]): void {
27-
console.log(args)
27+
console.log(args);
2828
this.inMemoryLogger['debug'].push(args.join(' '));
2929
}
3030

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
import {
2-
IConfig
3-
} from 'unleash-proxy-client';
1+
import { IConfig } from 'unleash-proxy-client';
42

5-
export interface UnleashConfig extends IConfig {
6-
}
3+
export type UnleashConfig = IConfig;

libs/providers/unleash-web/src/lib/unleash-web-provider.spec.ts

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,6 @@
11
import { UnleashWebProvider } from './unleash-web-provider';
22
import fetchMock, { enableFetchMocks } from 'jest-fetch-mock';
3-
import {
4-
EvaluationContext,
5-
OpenFeature,
6-
ProviderEvents,
7-
ProviderStatus,
8-
StandardResolutionReasons,
9-
ErrorCode,
10-
EvaluationDetails,
11-
JsonValue,
12-
} from '@openfeature/web-sdk';
3+
import { ProviderEvents } from '@openfeature/web-sdk';
134

145
import testdata from './testdata.json';
156
import TestLogger from './test-logger';
@@ -26,16 +17,14 @@ describe('UnleashWebProvider', () => {
2617
});
2718

2819
it('should be an instance of UnleashWebProvider', async () => {
29-
fetchMock.mockResponseOnce(JSON.stringify({"toggles":[]}));
30-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test',}, logger);
20+
fetchMock.mockResponseOnce(JSON.stringify({ toggles: [] }));
21+
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test' }, logger);
3122
await provider.initialize();
3223
expect(provider).toBeInstanceOf(UnleashWebProvider);
3324
});
34-
3525
});
3626

3727
describe('events', () => {
38-
3928
beforeEach(() => {
4029
fetchMock.resetMocks();
4130
});
@@ -45,9 +34,8 @@ describe('events', () => {
4534
});
4635

4736
it('should emit ProviderEvents.ConfigurationChanged and ProviderEvents.Ready events when provider is initialized', async () => {
48-
let provider: UnleashWebProvider;
49-
fetchMock.mockResponseOnce(JSON.stringify({"toggles":[]}));
50-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test',}, logger);
37+
fetchMock.mockResponseOnce(JSON.stringify({ toggles: [] }));
38+
const provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test' }, logger);
5139

5240
const configChangeHandler = jest.fn();
5341
const readyHandler = jest.fn();
@@ -63,9 +51,8 @@ describe('events', () => {
6351
});
6452

6553
it('should emit ProviderEvents.Error event when provider errors on initialization', async () => {
66-
let provider: UnleashWebProvider;
6754
fetchMock.mockResponseOnce('{}', { status: 401 });
68-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test',}, logger);
55+
const provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test' }, logger);
6956
const handler = jest.fn();
7057
provider.events.addHandler(ProviderEvents.Error, handler);
7158
await provider.initialize();
@@ -75,12 +62,14 @@ describe('events', () => {
7562
});
7663

7764
it('should emit ProviderEvents.ConfigurationChanged when the flags change', async () => {
78-
let provider: UnleashWebProvider;
79-
fetchMock.mockResponseOnce(JSON.stringify({"toggles":[]}));
80-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test', refreshInterval: 2}, logger);
65+
fetchMock.mockResponseOnce(JSON.stringify({ toggles: [] }));
66+
const provider = new UnleashWebProvider(
67+
{ url: endpoint, clientKey: 'clientsecret', appName: 'test', refreshInterval: 2 },
68+
logger,
69+
);
8170
await provider.initialize();
8271
await new Promise<void>((resolve) => {
83-
let configChangeHandler = function() {
72+
const configChangeHandler = function () {
8473
resolve();
8574
};
8675
provider.events.addHandler(ProviderEvents.ConfigurationChanged, configChangeHandler);
@@ -89,20 +78,22 @@ describe('events', () => {
8978
});
9079

9180
it('should emit ProviderEvents.Ready when provider recovers from an error', async () => {
92-
let provider: UnleashWebProvider;
93-
fetchMock.mockResponseOnce(JSON.stringify({"toggles":[]}));
94-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test', refreshInterval: 2}, logger);
81+
fetchMock.mockResponseOnce(JSON.stringify({ toggles: [] }));
82+
const provider = new UnleashWebProvider(
83+
{ url: endpoint, clientKey: 'clientsecret', appName: 'test', refreshInterval: 2 },
84+
logger,
85+
);
9586
await provider.initialize();
9687
await new Promise<void>((resolve) => {
97-
let errorHandler = function() {
88+
const errorHandler = function () {
9889
resolve();
9990
};
10091
provider.events.addHandler(ProviderEvents.Error, errorHandler);
10192
fetchMock.mockResponseOnce('{}', { status: 401 });
10293
});
10394

10495
await new Promise<void>((resolve) => {
105-
let readyHandler = function() {
96+
const readyHandler = function () {
10697
resolve();
10798
};
10899
provider.events.addHandler(ProviderEvents.Ready, readyHandler);
@@ -121,7 +112,7 @@ describe('UnleashWebProvider evaluations', () => {
121112
beforeAll(async () => {
122113
enableFetchMocks();
123114
fetchMock.mockResponseOnce(JSON.stringify(testdata));
124-
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test',}, logger);
115+
provider = new UnleashWebProvider({ url: endpoint, clientKey: 'clientsecret', appName: 'test' }, logger);
125116
await provider.initialize();
126117
});
127118

libs/providers/unleash-web/src/lib/unleash-web-provider.ts

Lines changed: 24 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,9 @@ import {
88
ProviderEvents,
99
ResolutionDetails,
1010
ProviderFatalError,
11-
StandardResolutionReasons
1211
} from '@openfeature/web-sdk';
13-
import {
14-
UnleashClient,
15-
IConfig,
16-
IContext,
17-
IMutableContext
18-
} from 'unleash-proxy-client';
19-
import {
20-
UnleashConfig
21-
} from './unleash-web-provider-config';
12+
import { UnleashClient } from 'unleash-proxy-client';
13+
import { UnleashConfig } from './unleash-web-provider-config';
2214

2315
export class UnleashWebProvider implements Provider {
2416
metadata = {
@@ -62,45 +54,45 @@ export class UnleashWebProvider implements Provider {
6254
this._client?.on('ready', () => {
6355
this._logger?.info('Unleash ready event received');
6456
this.events.emit(ProviderEvents.Ready, {
65-
message: 'Ready'
57+
message: 'Ready',
6658
});
6759
});
6860
this._client?.on('update', () => {
6961
this._logger?.info('Unleash update event received');
7062
this.events.emit(ProviderEvents.ConfigurationChanged, {
71-
message: 'Flags changed'
63+
message: 'Flags changed',
7264
});
7365
});
7466
this._client?.on('error', () => {
7567
this._logger?.info('Unleash error event received');
7668
this.events.emit(ProviderEvents.Error, {
77-
message: 'Error'
69+
message: 'Error',
7870
});
7971
});
8072
this._client?.on('recovered', () => {
8173
this._logger?.info('Unleash recovered event received');
8274
this.events.emit(ProviderEvents.Ready, {
83-
message: 'Recovered'
75+
message: 'Recovered',
8476
});
8577
});
8678
}
8779

8880
async onContextChange(_oldContext: EvaluationContext, newContext: EvaluationContext): Promise<void> {
89-
let unleashContext = new Map();
90-
let properties = new Map();
81+
const unleashContext = new Map();
82+
const properties = new Map();
9183
Object.keys(newContext).forEach((key) => {
9284
switch (key) {
93-
case "appName":
94-
case "userId":
95-
case "environment":
96-
case "remoteAddress":
97-
case "sessionId":
98-
case "currentTime":
99-
unleashContext.set(key, newContext[key]);
100-
break;
101-
default:
102-
properties.set(key, newContext[key]);
103-
break;
85+
case 'appName':
86+
case 'userId':
87+
case 'environment':
88+
case 'remoteAddress':
89+
case 'sessionId':
90+
case 'currentTime':
91+
unleashContext.set(key, newContext[key]);
92+
break;
93+
default:
94+
properties.set(key, newContext[key]);
95+
break;
10496
}
10597
});
10698
unleashContext.set('properties', properties);
@@ -119,16 +111,16 @@ export class UnleashWebProvider implements Provider {
119111
throw new FlagNotFoundError();
120112
}
121113
return {
122-
value: resp
123-
}
114+
value: resp,
115+
};
124116
}
125117

126118
resolveStringEvaluation(flagKey: string, defaultValue: string): ResolutionDetails<string> {
127119
return this.evaluate(flagKey, defaultValue);
128120
}
129121

130122
resolveNumberEvaluation(flagKey: string, defaultValue: number): ResolutionDetails<number> {
131-
let resolutionDetails = this.evaluate(flagKey, defaultValue);
123+
const resolutionDetails = this.evaluate(flagKey, defaultValue);
132124
resolutionDetails.value = Number(resolutionDetails.value);
133125
return resolutionDetails;
134126
}
@@ -140,15 +132,14 @@ export class UnleashWebProvider implements Provider {
140132
private evaluate<T>(flagKey: string, defaultValue: T): ResolutionDetails<T> {
141133
const evaluatedVariant = this._client?.getVariant(flagKey);
142134
let value;
143-
let variant
135+
let variant;
144136
if (typeof evaluatedVariant === 'undefined') {
145137
throw new FlagNotFoundError();
146138
}
147139

148140
if (evaluatedVariant.name === 'disabled') {
149141
value = defaultValue as T;
150-
}
151-
else {
142+
} else {
152143
variant = evaluatedVariant.name;
153144
value = evaluatedVariant.payload?.value;
154145
}

0 commit comments

Comments
 (0)