Skip to content

Commit 8662ea1

Browse files
chore: update OpenFeature SDKs to support hook data (#1392)
Signed-off-by: Lukas Reining <[email protected]>
1 parent 11400ef commit 8662ea1

File tree

5 files changed

+39
-17
lines changed

5 files changed

+39
-17
lines changed

libs/hooks/open-telemetry/src/lib/traces/tracing-hook.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import type { EvaluationDetails, HookContext } from '@openfeature/server-sdk';
2+
import { MapHookData } from '@openfeature/server-sdk';
23

34
const addEvent = jest.fn();
45
const recordException = jest.fn();
@@ -30,6 +31,7 @@ describe('OpenTelemetry Hooks', () => {
3031
defaultValue: true,
3132
flagValueType: 'boolean',
3233
logger: console,
34+
hookData: new MapHookData(),
3335
};
3436

3537
let tracingHook: TracingHook;

libs/providers/multi-provider-web/src/lib/multi-provider-web.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import type {
1010
ProviderMetadata,
1111
TrackingEventDetails,
1212
} from '@openfeature/web-sdk';
13+
import { MapHookData } from '@openfeature/web-sdk';
1314
import {
1415
DefaultLogger,
1516
ErrorCode,
@@ -21,7 +22,6 @@ import {
2122
import { FirstMatchStrategy } from './strategies/FirstMatchStrategy';
2223
import { FirstSuccessfulStrategy } from './strategies/FirstSuccessfulStrategy';
2324
import { ComparisonStrategy } from './strategies/ComparisonStrategy';
24-
import type { BaseEvaluationStrategy } from './strategies/BaseEvaluationStrategy';
2525

2626
class TestProvider implements Provider {
2727
public metadata: ProviderMetadata = {
@@ -64,6 +64,7 @@ const callBeforeHook = (
6464
clientMetadata: {} as any,
6565
providerMetadata: {} as any,
6666
logger: logger,
67+
hookData: new MapHookData(),
6768
};
6869
multi.hooks[0].before?.(hookContext);
6970
};
@@ -271,6 +272,7 @@ describe('MultiProvider', () => {
271272
clientMetadata: {} as any,
272273
providerMetadata: {} as any,
273274
logger: logger,
275+
hookData: new MapHookData(),
274276
};
275277

276278
provider1.hooks = [
@@ -350,6 +352,7 @@ describe('MultiProvider', () => {
350352
clientMetadata: {} as any,
351353
providerMetadata: {} as any,
352354
logger: logger,
355+
hookData: new MapHookData(),
353356
};
354357

355358
provider1.hooks = [

libs/providers/multi-provider/src/lib/multi-provider.spec.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,13 @@ import type {
44
FlagValue,
55
FlagValueType,
66
Hook,
7+
HookContext,
78
Logger,
89
Provider,
910
ProviderMetadata,
1011
TrackingEventDetails,
1112
} from '@openfeature/server-sdk';
13+
import { MapHookData } from '@openfeature/server-sdk';
1214
import {
1315
DefaultLogger,
1416
ErrorCode,
@@ -63,6 +65,7 @@ const callBeforeHook = async (
6365
clientMetadata: {} as any,
6466
providerMetadata: {} as any,
6567
logger: logger,
68+
hookData: new MapHookData(),
6669
};
6770
await multi.hooks[0].before?.(hookContext);
6871
};
@@ -262,14 +265,15 @@ describe('MultiProvider', () => {
262265
const context = {
263266
test: true,
264267
};
265-
const hookContext = {
268+
const hookContext: HookContext = {
266269
context: context,
267270
flagKey: 'flag',
268271
flagValueType: 'boolean' as any,
269272
defaultValue: false,
270273
clientMetadata: {} as any,
271274
providerMetadata: {} as any,
272275
logger: logger,
276+
hookData: new MapHookData(),
273277
};
274278

275279
const weakMap = new WeakMap();
@@ -371,6 +375,7 @@ describe('MultiProvider', () => {
371375
clientMetadata: {} as any,
372376
providerMetadata: {} as any,
373377
logger: logger,
378+
hookData: new MapHookData(),
374379
};
375380

376381
const weakMap = new WeakMap();

package-lock.json

Lines changed: 24 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@
5757
"@nx/rollup": "20.3.1",
5858
"@nx/web": "20.3.1",
5959
"@nx/workspace": "20.3.1",
60-
"@openfeature/core": "^1.6.0",
61-
"@openfeature/server-sdk": "^1.17.1",
62-
"@openfeature/web-sdk": "^1.4.1",
60+
"@openfeature/core": "^1.9.1",
61+
"@openfeature/server-sdk": "^1.19.0",
62+
"@openfeature/web-sdk": "^1.6.2",
6363
"@opentelemetry/sdk-metrics": "^1.15.0",
6464
"@swc-node/register": "~1.10.0",
6565
"@swc/cli": "~0.7.0",

0 commit comments

Comments
 (0)