fix(gofeatureflag): Error for configurationHasChanged when slash was missing in endpoint (#1229)

chrillebile · thomaspoignant · web-flow · commit ce6a8e1a8006 · 2025-04-11T15:30:13.000+02:00
Co-authored-by: Thomas Poignant &lt;thomas.poignant@gofeatureflag.org&gt;
diff --git a/libs/providers/go-feature-flag/src/lib/controller/goff-api.ts b/libs/providers/go-feature-flag/src/lib/controller/goff-api.ts
@@ -183,7 +183,8 @@ export class GoffApiController {
   }
 
   public async configurationHasChanged(): Promise<ConfigurationChange> {
-    const url = `${this.endpoint}v1/flag/change`;
+    const endpointURL = new URL(this.endpoint);
+    endpointURL.pathname = 'v1/flag/change';
 
     const headers: any = {
       'Content-Type': 'application/json',
@@ -193,7 +194,7 @@ export class GoffApiController {
       headers['If-None-Match'] = this.etag;
     }
     try {
-      const response = await axios.get(url, { headers });
+      const response = await axios.get(endpointURL.toString(), { headers });
       if (response.status === 304) {
         return ConfigurationChange.FLAG_CONFIGURATION_NOT_CHANGED;
       }

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,8 @@ export class GoffApiController {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`public async configurationHasChanged(): Promise<ConfigurationChange> {`
`186`		- const url = `${this.endpoint}v1/flag/change`;
	`186`	`+ const endpointURL = new URL(this.endpoint);`
	`187`	`+ endpointURL.pathname = 'v1/flag/change';`
`187`	`188`
`188`	`189`	`const headers: any = {`
`189`	`190`	`'Content-Type': 'application/json',`
`@@ -193,7 +194,7 @@ export class GoffApiController {`
`193`	`194`	`headers['If-None-Match'] = this.etag;`
`194`	`195`	`}`
`195`	`196`	`try {`
`196`		`- const response = await axios.get(url, { headers });`
	`197`	`+ const response = await axios.get(endpointURL.toString(), { headers });`
`197`	`198`	`if (response.status === 304) {`
`198`	`199`	`return ConfigurationChange.FLAG_CONFIGURATION_NOT_CHANGED;`
`199`	`200`	`}`