Skip to content

Commit e90fd0a

Browse files
committed
feat: added-linter-and-fixes
Signed-off-by: wadii <[email protected]>
1 parent 92e60e5 commit e90fd0a

File tree

5 files changed

+37
-21
lines changed

5 files changed

+37
-21
lines changed
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
{
2+
"extends": ["../../../.eslintrc.json"],
3+
"ignorePatterns": ["!**/*", "node_modules/**/*"],
4+
"overrides": [
5+
{
6+
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
7+
"rules": {}
8+
},
9+
{
10+
"files": ["*.ts", "*.tsx"],
11+
"rules": {}
12+
},
13+
{
14+
"files": ["*.js", "*.jsx"],
15+
"rules": {}
16+
}
17+
]
18+
}

libs/providers/flagsmith/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libs/providers/flagsmith/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@
77
},
88
"license": "Apache-2.0",
99
"dependencies": {
10-
"@openfeature/server-sdk": "^1.19.0",
10+
"@openfeature/server-sdk": "^1.17.1"
11+
},
12+
"devDependencies": {
1113
"flagsmith-nodejs": "^6.1.0"
1214
}
1315
}

libs/providers/flagsmith/src/lib/flagsmith-provider.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import FlagsmithOpenFeatureProvider from './flagsmith-provider';
2-
import { FlagNotFoundError, Logger, StandardResolutionReasons, ErrorCode, GeneralError } from '@openfeature/server-sdk';
3-
import { Flagsmith, Flags, BaseFlag } from 'flagsmith-nodejs';
2+
import { type Logger, StandardResolutionReasons, ErrorCode, GeneralError } from '@openfeature/server-sdk';
3+
import { type Flagsmith, type Flags, type BaseFlag } from 'flagsmith-nodejs';
44
import { mockFlagData } from './flagsmith.mocks';
55

66
jest.mock('flagsmith-nodejs');
@@ -129,7 +129,7 @@ describe('FlagsmithOpenFeatureProvider', () => {
129129
useFlagsmithDefaults: true,
130130
useBooleanConfigValue: false,
131131
});
132-
mockFlags.getFlag.mockReturnValue(undefined as any);
132+
mockFlags.getFlag.mockReturnValue(undefined as unknown as BaseFlag);
133133
const result = await provider.resolveBooleanEvaluation(
134134
'nonexistent-flag',
135135
false,
@@ -405,7 +405,7 @@ describe('FlagsmithOpenFeatureProvider', () => {
405405
it('should return a string when flag value is JSON', async () => {
406406
mockFlags.getFlag.mockReturnValue(mockFlagData.jsonValidFlag);
407407
const result = await defaultProvider.resolveStringEvaluation('test-flag', '', evaluationContext, loggerMock);
408-
expect(result.value).toBe('{\"key\": \"value\", \"nested\": {\"prop\": true}}');
408+
expect(result.value).toBe('{"key": "value", "nested": {"prop": true}}');
409409
expect(result.reason).toBe(StandardResolutionReasons.TARGETING_MATCH);
410410
});
411411
});

libs/providers/flagsmith/src/lib/flagsmith-provider.ts

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import {
2-
Provider,
3-
ProviderMetadata,
4-
ResolutionDetails,
5-
EvaluationContext,
6-
JsonValue,
2+
type Provider,
3+
type ProviderMetadata,
4+
type ResolutionDetails,
5+
type EvaluationContext,
6+
type JsonValue,
7+
type FlagValueType,
8+
type Logger,
9+
type FlagValue,
710
ErrorCode,
8-
FlagValueType,
9-
Logger,
10-
StandardResolutionReasons,
11-
FlagValue,
1211
GeneralError,
12+
StandardResolutionReasons,
1313
} from '@openfeature/server-sdk';
14-
import { Flags, Flagsmith, BaseFlag, TraitConfig, FlagsmithValue } from 'flagsmith-nodejs';
14+
import { type Flags, type Flagsmith, type BaseFlag, type TraitConfig, type FlagsmithValue } from 'flagsmith-nodejs';
1515
import { typeFactory } from './type-factory';
1616

1717
type FlagsmithTrait = Record<string, FlagsmithValue | TraitConfig>;
@@ -173,10 +173,6 @@ export default class FlagsmithOpenFeatureProvider implements Provider {
173173
}
174174

175175
async initialize(context?: EvaluationContext): Promise<void> {
176-
try {
177-
await this.getFlags(context || {});
178-
} catch (error) {
179-
throw error;
180-
}
176+
await this.getFlags(context || {});
181177
}
182178
}

0 commit comments

Comments
 (0)