fix(gofeatureflag): Error for configurationHasChanged when slash was missing in endpoint #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the endpoint did not have a trailing slash then configurationHasChanged would not work correctly. Signed-off-by: Christian Bilevits <[email protected]>
Member
|
@thomaspoignant any concerns with this? |
thomaspoignant
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
If the endpoint did not have a trailing slash then configurationHasChanged request would not work correctly, as it would try to do a request on
https://example.comv1/flag/changeinstead ofhttps://example.com/v1/flag/changeURL(this.endpoint) is being used for all other requests to mitigate this, except for configurationHasChanged.
How to test
Before you could not set the endpoint to
https://example.com, you had to sethttps://example.com/.Now you can set
https://example.comorhttps://example.com/.