Skip to content

fix(gofeatureflag): Error for configurationHasChanged when slash was missing in endpoint #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomaspoignant merged 2 commits into from
Apr 11, 2025
+3 −2
Merged

fix(gofeatureflag): Error for configurationHasChanged when slash was missing in endpoint #1229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e3ff6
Fix URL endpoint for configurationHasChanged
chrillebile Mar 17, 2025
d205dab
Merge branch 'main' into fix/url
thomaspoignant Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libs/providers/go-feature-flag/src/lib/controller/goff-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ export class GoffApiController {
}

public async configurationHasChanged(): Promise<ConfigurationChange> {
const url = `${this.endpoint}v1/flag/change`;
const endpointURL = new URL(this.endpoint);
endpointURL.pathname = 'v1/flag/change';

const headers: any = {
'Content-Type': 'application/json',
Expand All @@ -193,7 +194,7 @@ export class GoffApiController {
headers['If-None-Match'] = this.etag;
}
try {
const response = await axios.get(url, { headers });
const response = await axios.get(endpointURL.toString(), { headers });
if (response.status === 304) {
return ConfigurationChange.FLAG_CONFIGURATION_NOT_CHANGED;
}
Expand Down