Skip to content

chore: update OpenFeature SDKs to support hook data #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukas-reining merged 5 commits into from
Oct 8, 2025
Merged

chore: update OpenFeature SDKs to support hook data #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
031bf61
chore: update OF SDKs to support hook data
lukas-reining Oct 8, 2025
4efd668
chore: fix wrong import
lukas-reining Oct 8, 2025
c90744a
chore: fix wrong import
lukas-reining Oct 8, 2025
9f2ca32
chore: fix wrong import
lukas-reining Oct 8, 2025
6b29cfe
chore: fix wrong import
lukas-reining Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libs/hooks/open-telemetry/src/lib/traces/tracing-hook.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { EvaluationDetails, HookContext } from '@openfeature/server-sdk';
import { MapHookData } from '@openfeature/server-sdk';

const addEvent = jest.fn();
const recordException = jest.fn();
Expand Down Expand Up @@ -30,6 +31,7 @@ describe('OpenTelemetry Hooks', () => {
defaultValue: true,
flagValueType: 'boolean',
logger: console,
hookData: new MapHookData(),
};

let tracingHook: TracingHook;
Expand Down
5 changes: 4 additions & 1 deletion libs/providers/multi-provider-web/src/lib/multi-provider-web.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type {
ProviderMetadata,
TrackingEventDetails,
} from '@openfeature/web-sdk';
import { MapHookData } from '@openfeature/web-sdk';
import {
DefaultLogger,
ErrorCode,
Expand All @@ -21,7 +22,6 @@ import {
import { FirstMatchStrategy } from './strategies/FirstMatchStrategy';
import { FirstSuccessfulStrategy } from './strategies/FirstSuccessfulStrategy';
import { ComparisonStrategy } from './strategies/ComparisonStrategy';
import type { BaseEvaluationStrategy } from './strategies/BaseEvaluationStrategy';

class TestProvider implements Provider {
public metadata: ProviderMetadata = {
Expand Down Expand Up @@ -64,6 +64,7 @@ const callBeforeHook = (
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};
multi.hooks[0].before?.(hookContext);
};
Expand Down Expand Up @@ -271,6 +272,7 @@ describe('MultiProvider', () => {
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};

provider1.hooks = [
Expand Down Expand Up @@ -350,6 +352,7 @@ describe('MultiProvider', () => {
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};

provider1.hooks = [
Expand Down
7 changes: 6 additions & 1 deletion libs/providers/multi-provider/src/lib/multi-provider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@ import type {
FlagValue,
FlagValueType,
Hook,
HookContext,
Logger,
Provider,
ProviderMetadata,
TrackingEventDetails,
} from '@openfeature/server-sdk';
import { MapHookData } from '@openfeature/server-sdk';
import {
DefaultLogger,
ErrorCode,
Expand Down Expand Up @@ -63,6 +65,7 @@ const callBeforeHook = async (
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};
await multi.hooks[0].before?.(hookContext);
};
Expand Down Expand Up @@ -262,14 +265,15 @@ describe('MultiProvider', () => {
const context = {
test: true,
};
const hookContext = {
const hookContext: HookContext = {
context: context,
flagKey: 'flag',
flagValueType: 'boolean' as any,
defaultValue: false,
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};

const weakMap = new WeakMap();
Expand Down Expand Up @@ -371,6 +375,7 @@ describe('MultiProvider', () => {
clientMetadata: {} as any,
providerMetadata: {} as any,
logger: logger,
hookData: new MapHookData(),
};

const weakMap = new WeakMap();
Expand Down
36 changes: 24 additions & 12 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@
"@nx/rollup": "20.3.1",
"@nx/web": "20.3.1",
"@nx/workspace": "20.3.1",
"@openfeature/core": "^1.6.0",
"@openfeature/server-sdk": "^1.17.1",
"@openfeature/web-sdk": "^1.4.1",
"@openfeature/core": "^1.9.1",
"@openfeature/server-sdk": "^1.19.0",
"@openfeature/web-sdk": "^1.6.2",
"@opentelemetry/sdk-metrics": "^1.15.0",
"@swc-node/register": "~1.10.0",
"@swc/cli": "~0.7.0",
Expand Down