Skip to content

feat: Add tests for config feature #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 6 commits into from
Nov 28, 2025
Merged

feat: Add tests for config feature #1407

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01228f8
Merge branch 'main' into feat/add-unit-test-config-feature-1406
MarkoMlakar Nov 24, 2025
dafd6ba
Address test isolation and output formatting concerns
MarkoMlakar Nov 25, 2025
c9e41b7
Move env snapshot to function scope in configSteps
MarkoMlakar Nov 25, 2025
17f12da
Remove direct reassignment of the env variables and redundant test ti…
MarkoMlakar Nov 25, 2025
cfc6e2f
Improve test isolation and scenario name formatting
MarkoMlakar Nov 25, 2025
dbba301
Move the config feature unit test logic to configuration.spec
MarkoMlakar Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libs/providers/flagd/src/e2e/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ export const UNSTABLE_CLIENT_NAME = 'unstable';
export const UNAVAILABLE_CLIENT_NAME = 'unavailable';

export const GHERKIN_FLAGD = getGherkinTestPath('*.feature');
export const CONFIG_FEATURE = getGherkinTestPath('config.feature');
5 changes: 5 additions & 0 deletions libs/providers/flagd/src/e2e/step-definitions/configSteps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type { State, Steps } from './state';
import { CacheOption, getConfig, ResolverType } from '../../lib/configuration';
import { mapValueToType } from './utils';

const originalEnv = { ...process.env };

export const configSteps: Steps = (state: State) => {
function mapName(name: string): string {
switch (name) {
Expand All @@ -16,6 +18,9 @@ export const configSteps: Steps = (state: State) => {
return ({ given, when, then }: StepsDefinitionCallbackOptions) => {
beforeEach(() => {
state.options = {};
state.config = undefined;
state.events = [];
process.env = { ...originalEnv };
});
given(/^an option "(.*)" of type "(.*)" with value "(.*)"$/, (name: string, type: string, value: string) => {
state.options[mapName(name)] = mapValueToType(value, type);
Expand Down
23 changes: 23 additions & 0 deletions libs/providers/flagd/src/e2e/tests/config.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { configSteps } from '../step-definitions/configSteps';
import type { State } from '../step-definitions/state';
import { autoBindSteps, loadFeatures } from 'jest-cucumber';
import { CONFIG_FEATURE } from '../constants';

jest.setTimeout(50000);
describe('config', () => {
const state: State = {
resolverType: 'in-process',
options: {},
config: undefined,
events: [],
};
autoBindSteps(
loadFeatures(CONFIG_FEATURE, {
scenarioNameTemplate: (vars) => {
const tags = [...vars.scenarioTags, ...vars.featureTags];
return `${vars.scenarioTitle}${tags.length > 0 ? ` (${tags.join(', ')})` : ''}`;
},
}),
[configSteps(state)],
);
});