Skip to content

Conversation

@lukas-reining
Copy link
Member

Bumps @openfeature/ofrep-core dependencies to a new major version to keep old and new package versions compatible.

@lukas-reining lukas-reining requested review from a team as code owners November 24, 2025 13:31
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lukas-reining, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the core dependency @openfeature/ofrep-core to its latest major version across relevant provider modules. This ensures that the ofrep-web and ofrep providers are compatible with the most recent iteration of the core library, maintaining consistency and leveraging updated features. Additionally, it includes a configuration change to explicitly manage the release version for one of the affected providers.

Highlights

  • Dependency Update: The @openfeature/ofrep-core dependency has been bumped to its new major version ^2.0.0 in both the ofrep-web and ofrep providers.
  • Compatibility: This update ensures compatibility between old and new package versions, aligning with the latest core functionalities.
  • Release Configuration: The release-please-config.json has been updated to explicitly set the release-as version to 2.0.0 for the libs/providers/ofrep package.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @openfeature/ofrep-core dependency to a new major version (v2.0.0) for both the ofrep-web and ofrep providers, and configures release-please to create a 2.0.0 release for @openfeature/ofrep-core. My main concern is that bumping a dependency by a major version signals breaking changes, but there are no accompanying code modifications in the providers to address these potential changes. This could introduce runtime failures if the providers are not compatible with the new version of @openfeature/ofrep-core.

},
"dependencies": {
"@openfeature/ofrep-core": "^1.0.0"
"@openfeature/ofrep-core": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping @openfeature/ofrep-core to a new major version (^2.0.0) typically indicates breaking changes. The provider code, which depends on @openfeature/ofrep-core, has not been updated in this pull request. This introduces a risk of runtime failures if the provider is no longer compatible with the new API of the core package.

},
"dependencies": {
"@openfeature/ofrep-core": "^1.0.0"
"@openfeature/ofrep-core": "^2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Bumping @openfeature/ofrep-core to a new major version (^2.0.0) typically indicates breaking changes. The provider code, which depends on @openfeature/ofrep-core, has not been updated in this pull request. This introduces a risk of runtime failures if the provider is no longer compatible with the new API of the core package.

@lukas-reining lukas-reining force-pushed the fix/ofrep-core-dependencies branch from e61b6d1 to 00a2c5d Compare November 24, 2025 13:35
@lukas-reining lukas-reining merged commit b2135b4 into main Nov 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants