-
Notifications
You must be signed in to change notification settings - Fork 58
fix: dependencies of ofrep-web and ofrep provider #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lukas-reining, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the core dependency Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the @openfeature/ofrep-core dependency to a new major version (v2.0.0) for both the ofrep-web and ofrep providers, and configures release-please to create a 2.0.0 release for @openfeature/ofrep-core. My main concern is that bumping a dependency by a major version signals breaking changes, but there are no accompanying code modifications in the providers to address these potential changes. This could introduce runtime failures if the providers are not compatible with the new version of @openfeature/ofrep-core.
| }, | ||
| "dependencies": { | ||
| "@openfeature/ofrep-core": "^1.0.0" | ||
| "@openfeature/ofrep-core": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping @openfeature/ofrep-core to a new major version (^2.0.0) typically indicates breaking changes. The provider code, which depends on @openfeature/ofrep-core, has not been updated in this pull request. This introduces a risk of runtime failures if the provider is no longer compatible with the new API of the core package.
libs/providers/ofrep/package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@openfeature/ofrep-core": "^1.0.0" | ||
| "@openfeature/ofrep-core": "^2.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping @openfeature/ofrep-core to a new major version (^2.0.0) typically indicates breaking changes. The provider code, which depends on @openfeature/ofrep-core, has not been updated in this pull request. This introduces a risk of runtime failures if the provider is no longer compatible with the new API of the core package.
Signed-off-by: Lukas Reining <[email protected]>
e61b6d1 to
00a2c5d
Compare
Bumps @openfeature/ofrep-core dependencies to a new major version to keep old and new package versions compatible.