Commit 14441b1
authored
fix: remove events.js from core module (#650)
Optimization to `@openfeature/core` package. Both server and web need
the node-js `Events` interfaces, but obviously only the web needs them
poly-filled (they come with node).
This PR:
- marks `events.js` as an external dep in `@openfeature/core` meaning it
won't be bundled there (see esbuild
[doc](https://esbuild.github.io/api/#external))
This means that now `@openfeature/core` no longer includes `events.js`
(an un-needed polyfill for the server). The bundling pictured below only
happens in the `dist/` of `@openfeature/web-sdk`, and no longer in
`@openfeature/core` :

I've tested both the server and web SDKs based on this change locally in
the js-contribs by running the e2e test suite.
Relates to: #616
Signed-off-by: Todd Baert <[email protected]>1 parent e72fc19 commit 14441b1
File tree
1 file changed
+2
-2
lines changed1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
0 commit comments