Skip to content

Commit 54ee795

Browse files
fix: address remaining PR review comments for server SDK
Signed-off-by: Jonathan Norris <[email protected]>
1 parent ea3f3ef commit 54ee795

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

packages/server/README.md

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,16 +205,14 @@ import { OpenFeature, MultiProvider, ComparisonStrategy } from '@openfeature/ser
205205
const providerA = new ProviderA();
206206
const providerB = new ProviderB();
207207

208-
const comparisonStrategy = new ComparisonStrategy({
209-
primary: 0, // Use first provider as primary
210-
onMismatch: (flagKey, primaryResult, results) => {
211-
console.warn(`Mismatch for ${flagKey}:`, primaryResult, results);
212-
}
213-
});
214-
215208
const multiProvider = new MultiProvider(
216-
[providerA, providerB],
217-
comparisonStrategy
209+
[
210+
{ provider: providerA },
211+
{ provider: providerB }
212+
],
213+
new ComparisonStrategy(providerA, (resolutions) => {
214+
console.warn('Mismatch detected', resolutions);
215+
})
218216
);
219217

220218
await OpenFeature.setProviderAndWait(multiProvider);

packages/server/src/provider/multi-provider/status-tracker.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ export class StatusTracker {
5555
this.providerStatuses[name] = status;
5656
const newStatus = this.getStatusFromProviderStatuses();
5757
if (currentStatus !== newStatus) {
58-
if (newStatus === ProviderStatus.FATAL) {
59-
this.events.emit(ProviderEvents.Error, details);
60-
} else if (newStatus === ProviderStatus.ERROR) {
58+
if (newStatus === ProviderStatus.FATAL || newStatus === ProviderStatus.ERROR) {
6159
this.events.emit(ProviderEvents.Error, details);
6260
} else if (newStatus === ProviderStatus.STALE) {
6361
this.events.emit(ProviderEvents.Stale, details);

0 commit comments

Comments
 (0)