Skip to content

Commit 55acc05

Browse files
authored
feat: add caching for pipelines (#384)
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - adds npm caching in all pipelines, with cache setup node takes 5s against 12s of before ![image](https://user-images.githubusercontent.com/89971034/227175858-703a6145-dced-425b-9ca1-19c7851c5b7a.png) ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #310 ### Notes <!-- any additional notes for this PR --> since 14 is now too old, we decided that 16 was the best version to avoid breaking changes --------- Signed-off-by: realanna <[email protected]>
1 parent 818ec5c commit 55acc05

File tree

5 files changed

+10
-1
lines changed

5 files changed

+10
-1
lines changed

.github/workflows/coverage.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ jobs:
1616
- uses: actions/setup-node@v3
1717
with:
1818
registry-url: 'https://registry.npmjs.org'
19+
node-version: 16
20+
cache: 'npm'
1921

2022
- name: Install
2123
run: npm ci

.github/workflows/pr-checks.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ jobs:
2222
steps:
2323
- uses: actions/checkout@v3
2424
- uses: actions/setup-node@v3
25+
with:
26+
node-version: 16
27+
cache: 'npm'
2528

2629
- name: Install
2730
run: npm ci

.github/workflows/release-please.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
with:
3232
node-version: 16
3333
registry-url: "https://registry.npmjs.org"
34+
cache: 'npm'
3435
- name: Build Packages
3536
run: |
3637
npm ci

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
},
3030
"homepage": "https://github.com/open-feature/js-sdk#readme",
3131
"engines": {
32-
"node": ">=14"
32+
"node": ">=16"
3333
},
3434
"devDependencies": {
3535
"@openfeature/flagd-provider": "~0.7.0",

packages/server/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@
4444
"url": "https://github.com/open-feature/js-sdk/issues"
4545
},
4646
"homepage": "https://github.com/open-feature/js-sdk#readme",
47+
"engines": {
48+
"node": ">=16"
49+
},
4750
"devDependencies": {
4851
"@openfeature/shared": "0.0.2"
4952
}

0 commit comments

Comments
 (0)