Skip to content

Commit 618d404

Browse files
committed
fix(angular): fix race condition on initialization
Signed-off-by: Lukas Reining <[email protected]>
1 parent 4849306 commit 618d404

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

packages/angular/projects/angular-sdk/src/lib/feature-flag.directive.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import {
55
Input,
66
OnChanges,
77
OnDestroy,
8+
OnInit,
89
TemplateRef,
910
ViewContainerRef,
1011
} from '@angular/core';
@@ -33,7 +34,7 @@ class FeatureFlagDirectiveContext<T extends FlagValue> {
3334
standalone: true,
3435
selector: '[featureFlag]',
3536
})
36-
export abstract class FeatureFlagDirective<T extends FlagValue> implements OnDestroy, OnChanges {
37+
export abstract class FeatureFlagDirective<T extends FlagValue> implements OnInit, OnDestroy, OnChanges {
3738
protected _featureFlagDefault: T;
3839
protected _featureFlagDomain: string | undefined;
3940

@@ -69,14 +70,17 @@ export abstract class FeatureFlagDirective<T extends FlagValue> implements OnDes
6970
templateRef: TemplateRef<FeatureFlagDirectiveContext<T>>,
7071
) {
7172
this._thenTemplateRef = templateRef;
72-
this.initClient();
7373
}
7474

7575
set featureFlagDomain(domain: string | undefined) {
7676
this._featureFlagDomain = domain;
7777
this.initClient();
7878
}
7979

80+
ngOnInit(): void {
81+
this.initClient();
82+
}
83+
8084
ngOnChanges(): void {
8185
this._flagChangeHandler?.();
8286
}
@@ -200,7 +204,7 @@ export abstract class FeatureFlagDirective<T extends FlagValue> implements OnDes
200204
* Usage examples:
201205
*
202206
* ```
203-
* <div *booleanFeatureFlag="'flagKey'; default: 0; let value">{{ value }}</div>
207+
* <div *booleanFeatureFlag="'flagKey'; default: false; let value">{{ value }}</div>
204208
* ```
205209
* ```
206210
* <div *booleanFeatureFlag="flagKey; default: false; else: elseTemplate">Content to render when flag is true.</div>

0 commit comments

Comments
 (0)