fixup: try/catch and freeze context

Signed-off-by: Todd Baert <[email protected]>

Author: toddbaert

packages/server/src/client/internal/open-feature-client.ts

@@ -225,15 +225,19 @@ export class OpenFeatureClient implements Client {
   }
 
   track(occurrenceKey: string, context: EvaluationContext, occurrenceDetails: TrackingEventDetails): void {
+    try {
+      this.shortCircuitIfNotReady();
 
-    this.shortCircuitIfNotReady();
-
-    const mergedContext = this.mergeContexts(context);
+      const mergedContext = this.mergeContexts(context);
+      Object.freeze(mergedContext);
 
-    if (typeof this._provider.track === 'function') {
-      return this._provider.track?.(occurrenceKey, mergedContext, occurrenceDetails);
-    } else {
-      this._logger.debug('Provider does not implement track function: will no-op.');
+      if (typeof this._provider.track === 'function') {
+        return this._provider.track?.(occurrenceKey, mergedContext, occurrenceDetails);
+      } else {
+        this._logger.debug('Provider does not support the track function; will no-op.');
+      }
+    } catch (err) {
+      this._logger.debug('Error recording tracking event.', err);
     }
   }
 

packages/server/test/client.spec.ts

@@ -837,11 +837,25 @@ describe('OpenFeatureClient', () => {
       const invocationContextValue = 'invocationValue';
 
       it('should no-op and not throw if tracking not defined on provider', async () => {
-        await OpenFeature.setProviderAndWait({ ...MOCK_PROVIDER, initialize: undefined });
+        await OpenFeature.setProviderAndWait({ ...MOCK_PROVIDER, track: undefined });
         const client = OpenFeature.getClient();
 
         expect(() => {
-          client.track(eventName, trackingDetails);
+          client.track(eventName, {}, trackingDetails);
+        }).not.toThrow();
+      });
+
+      it('should no-op and not throw if provider throws', async () => {
+        await OpenFeature.setProviderAndWait({
+          ...MOCK_PROVIDER,
+          track: () => {
+            throw new Error('fake error');
+          },
+        });
+        const client = OpenFeature.getClient();
+
+        expect(() => {
+          client.track(eventName, {}, trackingDetails);
         }).not.toThrow();
       });
 

packages/web/src/client/internal/open-feature-client.ts

@@ -183,17 +183,22 @@ export class OpenFeatureClient implements Client {
   }
 
   track(occurrenceKey: string, occurrenceDetails: TrackingEventDetails): void {
+    try {
+      this.shortCircuitIfNotReady();
 
-    this.shortCircuitIfNotReady();
-
-    const context = {
-      ...OpenFeature.getContext(this?.options?.domain),
-    };
+      // copy and freeze the context
+      const context = {
+        ...OpenFeature.getContext(this?.options?.domain),
+      };
+      Object.freeze(context);
 
-    if (typeof this._provider.track === 'function') {
-      return this._provider.track?.(occurrenceKey, context, occurrenceDetails);
-    } else {
-      this._logger.debug('Provider does not implement track function: will no-op.');
+      if (typeof this._provider.track === 'function') {
+        return this._provider.track?.(occurrenceKey, context, occurrenceDetails);
+      } else {
+        this._logger.debug('Provider does not support the track function; will no-op.');
+      }
+    } catch (err) {
+      this._logger.debug('Error recording tracking event.', err);
     }
   }
 

packages/web/test/client.spec.ts

@@ -647,7 +647,21 @@ describe('OpenFeatureClient', () => {
       const contextValue = 'val';
 
       it('should no-op and not throw if tracking not defined on provider', async () => {
-        await OpenFeature.setProviderAndWait({ ...MOCK_PROVIDER, initialize: undefined });
+        await OpenFeature.setProviderAndWait({ ...MOCK_PROVIDER, track: undefined });
+        const client = OpenFeature.getClient();
+
+        expect(() => {
+          client.track(eventName, trackingDetails);
+        }).not.toThrow();
+      });
+
+      it('should no-op and not throw if provider throws', async () => {
+        await OpenFeature.setProviderAndWait({
+          ...MOCK_PROVIDER,
+          track: () => {
+            throw new Error('fake error');
+          },
+        });
         const client = OpenFeature.getClient();
 
         expect(() => {