feat: lower compilation target to es2015 (#957)

beeme1mr · web-flow · commit c2d6c1761ae1 · 2024-06-11T12:47:19.000Z
## This PR - replace the es2022 error cause with a custom implementation - lower compilation target from es2022 to es2015 ### Related Issues Fixes #956 ### Notes The tests pass, but I still want to manually build and test the outputs in a real application to ensure everything works as expected. Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -8,7 +8,7 @@ node 16+, npm 8+ are recommended.
 
 ### Compilation Target(s)
 
-We target `es2022`, and publish both ES-modules and CommonJS modules.
+We target `es2015`, and publish both ES-modules and CommonJS modules.
 
 ### Installation and Dependencies
 
diff --git a/packages/client/README.md b/packages/client/README.md
@@ -44,7 +44,7 @@
 
 ### Requirements
 
-- ES2022-compatible web browser (Chrome, Edge, Firefox, etc)
+- ES2015-compatible web browser (Chrome, Edge, Firefox, etc)
 
 ### Install
 
diff --git a/packages/client/package.json b/packages/client/package.json
@@ -17,8 +17,8 @@
     "test": "jest --verbose",
     "lint": "eslint ./",
     "clean": "shx rm -rf ./dist",
-    "build:web-esm": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2022 --platform=browser --format=esm --outfile=./dist/esm/index.js --analyze",
-    "build:web-cjs": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2022 --platform=browser --format=cjs --outfile=./dist/cjs/index.js --analyze",
+    "build:web-esm": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2015 --platform=browser --format=esm --outfile=./dist/esm/index.js --analyze",
+    "build:web-cjs": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2015 --platform=browser --format=cjs --outfile=./dist/cjs/index.js --analyze",
     "build:rollup-types": "rollup -c ../../rollup.config.mjs",
     "build": "npm run clean && npm run build:web-esm && npm run build:web-cjs && npm run build:rollup-types",
     "postbuild": "shx cp ./../../package.esm.json ./dist/esm/package.json",
@@ -51,4 +51,4 @@
   "devDependencies": {
     "@openfeature/core": "1.2.0"
   }
-}
+}
diff --git a/packages/client/src/provider/in-memory-provider/in-memory-provider.ts b/packages/client/src/provider/in-memory-provider/in-memory-provider.ts
@@ -38,7 +38,7 @@ export class InMemoryProvider implements Provider {
       }
       this._context = context;
     } catch (err) {
-      throw new Error('initialization failure', { cause: err });
+      throw new GeneralError('initialization failure', { cause: err });
     }
   }
 
diff --git a/packages/client/tsconfig.json b/packages/client/tsconfig.json
@@ -9,9 +9,9 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2015", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022",
+      "ES2015",
       "DOM"
     ], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
@@ -24,7 +24,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022", /* Specify what module code is generated. */
+    "module": "ES2015", /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
diff --git a/packages/nest/package.json b/packages/nest/package.json
@@ -17,8 +17,8 @@
     "test": "jest --verbose",
     "lint": "eslint ./",
     "clean": "shx rm -rf ./dist",
-    "build:esm": "esbuild src/index.ts --bundle --external:@nestjs/* --external:@openfeature/server-sdk --sourcemap --target=es2022 --platform=node --format=esm --outfile=./dist/esm/index.js --analyze",
-    "build:cjs": "esbuild src/index.ts --bundle --external:@nestjs/* --external:@openfeature/server-sdk --sourcemap --target=es2022 --platform=node --format=cjs --outfile=./dist/cjs/index.js --analyze",
+    "build:esm": "esbuild src/index.ts --bundle --external:@nestjs/* --external:@openfeature/server-sdk --sourcemap --target=es2015 --platform=node --format=esm --outfile=./dist/esm/index.js --analyze",
+    "build:cjs": "esbuild src/index.ts --bundle --external:@nestjs/* --external:@openfeature/server-sdk --sourcemap --target=es2015 --platform=node --format=cjs --outfile=./dist/cjs/index.js --analyze",
     "build:rollup-types": "rollup -c ../../rollup.config.mjs",
     "build": "npm run clean && npm run build:esm && npm run build:cjs && npm run build:rollup-types",
     "postbuild": "shx cp ./../../package.esm.json ./dist/esm/package.json",
@@ -60,4 +60,4 @@
     "@types/supertest": "^6.0.0",
     "supertest": "^7.0.0"
   }
-}
+}
diff --git a/packages/nest/tsconfig.json b/packages/nest/tsconfig.json
@@ -9,10 +9,10 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022",
+    "target": "ES2015",
     /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022"
+      "ES2015"
     ],
     /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
@@ -27,7 +27,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022",
+    "module": "ES2015",
     /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node",
diff --git a/packages/react/README.md b/packages/react/README.md
@@ -61,7 +61,7 @@ In addition to the feature provided by the [web sdk](https://openfeature.dev/doc
 
 ### Requirements
 
-- ES2022-compatible web browser (Chrome, Edge, Firefox, etc)
+- ES2015-compatible web browser (Chrome, Edge, Firefox, etc)
 - React version 16.8+
 
 ### Install
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -17,8 +17,8 @@
     "test": "jest --verbose",
     "lint": "eslint ./",
     "clean": "shx rm -rf ./dist",
-    "build:react-esm": "esbuild src/index.ts --bundle  --external:react --external:@openfeature/web-sdk --sourcemap --target=es2022 --platform=browser --format=esm --outfile=./dist/esm/index.js --analyze",
-    "build:react-cjs": "esbuild src/index.ts --bundle  --external:react --external:@openfeature/web-sdk --sourcemap --target=es2022 --platform=browser --format=cjs --outfile=./dist/cjs/index.js --analyze",
+    "build:react-esm": "esbuild src/index.ts --bundle  --external:react --external:@openfeature/web-sdk --sourcemap --target=es2015 --platform=browser --format=esm --outfile=./dist/esm/index.js --analyze",
+    "build:react-cjs": "esbuild src/index.ts --bundle  --external:react --external:@openfeature/web-sdk --sourcemap --target=es2015 --platform=browser --format=cjs --outfile=./dist/cjs/index.js --analyze",
     "build:rollup-types": "rollup -c ../../rollup.config.mjs",
     "build": "npm run clean && npm run build:react-esm && npm run build:react-cjs && npm run build:rollup-types",
     "postbuild": "shx cp ./../../package.esm.json ./dist/esm/package.json",
@@ -53,4 +53,4 @@
     "@openfeature/core": "*",
     "@openfeature/web-sdk": "*"
   }
-}
+}
diff --git a/packages/react/tsconfig.json b/packages/react/tsconfig.json
@@ -10,9 +10,9 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2015", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022",
+      "ES2015",
       "DOM"
     ], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
@@ -25,7 +25,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022", /* Specify what module code is generated. */
+    "module": "ES2015", /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
diff --git a/packages/server/package.json b/packages/server/package.json
@@ -17,8 +17,8 @@
     "test": "jest --verbose",
     "lint": "eslint ./",
     "clean": "shx rm -rf ./dist",
-    "build:esm": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2022 --platform=node --format=esm --outfile=./dist/esm/index.js --analyze",
-    "build:cjs": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2022 --platform=node --format=cjs --outfile=./dist/cjs/index.js --analyze",
+    "build:esm": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2015 --platform=node --format=esm --outfile=./dist/esm/index.js --analyze",
+    "build:cjs": "esbuild src/index.ts --bundle --external:@openfeature/core --sourcemap --target=es2015 --platform=node --format=cjs --outfile=./dist/cjs/index.js --analyze",
     "build:rollup-types": "rollup -c ../../rollup.config.mjs",
     "build": "npm run clean && npm run build:esm && npm run build:cjs && npm run build:rollup-types",
     "postbuild": "shx cp ./../../package.esm.json ./dist/esm/package.json",
@@ -53,4 +53,4 @@
   "devDependencies": {
     "@openfeature/core": "1.2.0"
   }
-}
+}
diff --git a/packages/server/tsconfig.json b/packages/server/tsconfig.json
@@ -9,9 +9,9 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2015", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022",
+      "ES2015",
     ], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
@@ -23,7 +23,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022", /* Specify what module code is generated. */
+    "module": "ES2015", /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -19,8 +19,8 @@
     "lint": "eslint ./",
     "clean": "shx rm -rf ./dist",
     "type": "tsc --project ./tsconfig.json --declaration --emitDeclarationOnly",
-    "build:esm": "esbuild src/index.ts --bundle --external:events --sourcemap --target=es2022 --format=esm --outfile=./dist/esm/index.js --analyze",
-    "build:cjs": "esbuild src/index.ts --bundle --external:events --sourcemap --target=es2022 --format=cjs --outfile=./dist/cjs/index.js --analyze",
+    "build:esm": "esbuild src/index.ts --bundle --external:events --sourcemap --target=es2015 --format=esm --outfile=./dist/esm/index.js --analyze",
+    "build:cjs": "esbuild src/index.ts --bundle --external:events --sourcemap --target=es2015 --format=cjs --outfile=./dist/cjs/index.js --analyze",
     "build:rollup-types": "rollup -c ../../rollup.config.mjs",
     "build": "npm run clean && npm run build:esm && npm run build:cjs && npm run build:rollup-types",
     "postbuild": "shx cp ./../../package.esm.json ./dist/esm/package.json",
@@ -45,4 +45,4 @@
     "flags",
     "toggles"
   ]
-}
+}
diff --git a/packages/shared/src/errors/flag-not-found-error.ts b/packages/shared/src/errors/flag-not-found-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class FlagNotFoundError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/general-error.ts b/packages/shared/src/errors/general-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class GeneralError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/invalid-context-error.ts b/packages/shared/src/errors/invalid-context-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class InvalidContextError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/open-feature-error-abstract.ts b/packages/shared/src/errors/open-feature-error-abstract.ts
@@ -1,10 +1,20 @@
 import { ErrorCode } from '../evaluation';
 
+/**
+ * Error Options were added in ES2022. Manually adding the type so that an
+ * earlier target can be used.
+ */
+export type ErrorOptions = {
+  cause?: unknown
+};
+
 export abstract class OpenFeatureError extends Error {
   abstract code: ErrorCode;
+  cause?: unknown;
   constructor(message?: string, options?: ErrorOptions) {
-    super(message, options);
+    super(message);
     Object.setPrototypeOf(this, OpenFeatureError.prototype);
     this.name = 'OpenFeatureError';
+    this.cause = options?.cause;
   }
 }
diff --git a/packages/shared/src/errors/parse-error.ts b/packages/shared/src/errors/parse-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class ParseError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/provider-fatal-error.ts b/packages/shared/src/errors/provider-fatal-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class ProviderFatalError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/provider-not-ready-error.ts b/packages/shared/src/errors/provider-not-ready-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class ProviderNotReadyError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/targeting-key-missing-error.ts b/packages/shared/src/errors/targeting-key-missing-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class TargetingKeyMissingError extends OpenFeatureError {
diff --git a/packages/shared/src/errors/type-mismatch-error.ts b/packages/shared/src/errors/type-mismatch-error.ts
@@ -1,4 +1,4 @@
-import { OpenFeatureError } from './open-feature-error-abstract';
+import { ErrorOptions, OpenFeatureError } from './open-feature-error-abstract';
 import { ErrorCode } from '../evaluation';
 
 export class TypeMismatchError extends OpenFeatureError {
diff --git a/packages/shared/tsconfig.json b/packages/shared/tsconfig.json
@@ -9,9 +9,9 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2015", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022"
+      "ES2015"
     ], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
     // "experimentalDecorators": true,                   /* Enable experimental support for TC39 stage 2 draft decorators. */
@@ -23,7 +23,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022", /* Specify what module code is generated. */
+    "module": "ES2015", /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */
diff --git a/tsconfig.json b/tsconfig.json
@@ -9,9 +9,9 @@
     // "disableSolutionSearching": true,                 /* Opt a project out of multi-project reference checking when editing. */
     // "disableReferencedProjectLoad": true,             /* Reduce the number of projects loaded automatically by TypeScript. */
     /* Language and Environment */
-    "target": "ES2022", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
+    "target": "ES2015", /* Set the JavaScript language version for emitted JavaScript and include compatible library declarations. */
     "lib": [
-      "ES2022",
+      "ES2015",
       "DOM"
     ], /* Specify a set of bundled library declaration files that describe the target runtime environment. */
     // "jsx": "preserve",                                /* Specify what JSX code is generated. */
@@ -24,7 +24,7 @@
     // "noLib": true,                                    /* Disable including any library files, including the default lib.d.ts. */
     // "useDefineForClassFields": true,                  /* Emit ECMAScript-standard-compliant class fields. */
     /* Modules */
-    "module": "ES2022", /* Specify what module code is generated. */
+    "module": "ES2015", /* Specify what module code is generated. */
     // "rootDir": "./",                                  /* Specify the root folder within your source files. */
     "moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
     // "baseUrl": "./",                                  /* Specify the base directory to resolve non-relative module names. */

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ export class InMemoryProvider implements Provider {`
`38`	`38`	`}`
`39`	`39`	`this._context = context;`
`40`	`40`	`} catch (err) {`
`41`		`- throw new Error('initialization failure', { cause: err });`
	`41`	`+ throw new GeneralError('initialization failure', { cause: err });`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`