Skip to content

Commit ea36416

Browse files
committed
fix(angular): add comment for why domain change has to be handled explicitly
Signed-off-by: Lukas Reining <[email protected]>
1 parent 71a2a7f commit ea36416

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

packages/angular/projects/angular-sdk/src/lib/feature-flag.directive.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,10 @@ export abstract class FeatureFlagDirective<T extends FlagValue> implements OnIni
7373
}
7474

7575
set featureFlagDomain(domain: string | undefined) {
76+
/**
77+
* We have to handle the change of the domain explicitly because we need to get a new client when the domain changes.
78+
* This can not be done if we simply relay the onChanges method.
79+
*/
7680
this._featureFlagDomain = domain;
7781
this.initClient();
7882
}

0 commit comments

Comments
 (0)