Skip to content

fix: await context change in useContextMutator setContext #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: await context change in useContextMutator setContext #1306

wants to merge 1 commit into from

Conversation

@MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Dec 2, 2025

This PR

As identified in #1305 (comment), the signature + JSDoc for this hook method indicates it returns a Promise you can await for the context change, however, the actual logic within the method did not await the underlying setContext calls -- it now does.

@MattIPv4 MattIPv4 requested review from a team as code owners December 2, 2025 22:50
@MattIPv4 MattIPv4 mentioned this pull request Dec 2, 2025
Open
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 2, 2025

Summary of Changes

Hello @MattIPv4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency in the useContextMutator hook where its setContext method was declared as asynchronous but did not actually await the internal context updates. By incorporating the await keyword, the method now correctly fulfills its promise-returning contract, guaranteeing that context modifications are fully processed before any subsequent operations. This enhancement significantly improves the reliability and predictability of context management within the React SDK.

Highlights

  • Asynchronous Context Updates: The setContext method within useContextMutator now correctly awaits the underlying OpenFeature.setContext calls. This change aligns the implementation with its JSDoc and signature, which indicate that it returns a Promise, ensuring that context changes are properly handled asynchronously.
  • Test Suite Enhancements: Existing tests for useContextMutator have been updated to accurately reflect the asynchronous nature of context changes. This includes the introduction of a loading state in the MutateButton component and adjustments to waitFor timeouts, ensuring robust testing of the new asynchronous behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where setContext in useContextMutator didn't await the underlying context change promise. The fix is correct and simply adds the await keyword. The tests have been significantly improved to validate this asynchronous behavior by introducing a loading state and waiting for it to resolve, which makes them more reliable. I've added a couple of suggestions to further improve the test suite's robustness by avoiding indexed element selection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MattIPv4