Lets favor not throwing in the FirstMatchStrategy also

PenguinDan · PenguinDan · commit 870ae07d18e7 · 2025-08-26T10:39:51.000-07:00
Signed-off-by: penguindan &lt;daniel.seunkim@gmail.com&gt;
diff --git a/kotlin-sdk/src/commonMain/kotlin/dev/openfeature/kotlin/sdk/multiprovider/FirstMatchStrategy.kt b/kotlin-sdk/src/commonMain/kotlin/dev/openfeature/kotlin/sdk/multiprovider/FirstMatchStrategy.kt
@@ -35,12 +35,17 @@ class FirstMatchStrategy : MultiProvider.Strategy {
                 if (eval.errorCode != ErrorCode.FLAG_NOT_FOUND) {
                     return eval
                 }
-                // Continue to next provider if error is FLAG_NOT_FOUND
             } catch (_: OpenFeatureError.FlagNotFoundError) {
                 // Handle FLAG_NOT_FOUND exception - continue to next provider
                 continue
+            } catch (error: OpenFeatureError) {
+                return ProviderEvaluation(
+                    defaultValue,
+                    reason = Reason.ERROR.toString(),
+                    errorCode = error.errorCode(),
+                    errorMessage = error.message,
+                )
             }
-            // We don't catch any other exception, but rather, bubble up the exceptions
         }
 
         // No provider knew about the flag, return default value with DEFAULT reason

Original file line number	Diff line number	Diff line change
`@@ -35,12 +35,17 @@ class FirstMatchStrategy : MultiProvider.Strategy {`
`35`	`35`	`if (eval.errorCode != ErrorCode.FLAG_NOT_FOUND) {`
`36`	`36`	`return eval`
`37`	`37`	`}`
`38`		`- // Continue to next provider if error is FLAG_NOT_FOUND`
`39`	`38`	`} catch (_: OpenFeatureError.FlagNotFoundError) {`
`40`	`39`	`// Handle FLAG_NOT_FOUND exception - continue to next provider`
`41`	`40`	`continue`
	`41`	`+ } catch (error: OpenFeatureError) {`
	`42`	`+ return ProviderEvaluation(`
	`43`	`+ defaultValue,`
	`44`	`+ reason = Reason.ERROR.toString(),`
	`45`	`+ errorCode = error.errorCode(),`
	`46`	`+ errorMessage = error.message,`
	`47`	`+ )`
`42`	`48`	`}`
`43`		`- // We don't catch any other exception, but rather, bubble up the exceptions`
`44`	`49`	`}`
`45`	`50`
`46`	`51`	`// No provider knew about the flag, return default value with DEFAULT reason`