nil pointer dereference and index simplification

Signed-off-by: James Milligan <[email protected]>

Author: james-milligan

webhooks/pod_webhook.go

@@ -417,19 +417,25 @@ func setSecurityContext() *corev1.SecurityContext {
 }
 
 func OpenFeatureEnabledAnnotationIndex(o client.Object) []string {
-	val, ok := o.(*corev1.Pod).ObjectMeta.Annotations["openfeature.dev/enabled"]
-	if !ok || val != "true" {
-		val, ok := o.(*corev1.Pod).ObjectMeta.Annotations["openfeature.dev"]
-		if ok && val == "enabled" {
-			return []string{
-				"true",
-			}
-		}
+	pod := o.(*corev1.Pod)
+	if pod.ObjectMeta.Annotations == nil {
 		return []string{
 			"false",
 		}
 	}
+	val, ok := pod.ObjectMeta.Annotations["openfeature.dev/enabled"]
+	if ok && val == "true" {
+		return []string{
+			"true",
+		}
+	}
+	val, ok = pod.ObjectMeta.Annotations["openfeature.dev"]
+	if ok && val == "enabled" {
+		return []string{
+			"true",
+		}
+	}
 	return []string{
-		"true",
+		"false",
 	}
 }