Skip to content

Commit 640ff10

Browse files
toddbaerttoddbaert
authored
fix!: remove flagdResourceEnabled (#652)
Signed-off-by: Todd Baert <[email protected]>
1 parent 1ea457f commit 640ff10

13 files changed

+46
-225
lines changed

‎chart/open-feature-operator/.gitignore‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,3 @@ templates/crds/*.yaml
44
# the following files are not generated, they are special cases
55
!templates/namespace.yaml
66
!templates/admissionregistration.k8s.io_v1_validatingwebhookconfiguration_open-feature-operator-validating-webhook-configuration.yaml
7-
!templates/rbac.authorization.k8s.io_v1_clusterrole_open-feature-operator-manager-role.yaml
8-
!templates/rbac.authorization.k8s.io_v1_clusterrolebinding_open-feature-operator-manager-rolebinding.yaml

‎chart/open-feature-operator/README.md‎

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -157,23 +157,22 @@ The command removes all the Kubernetes components associated with the chart and
157157

158158
### Operator resource configuration
159159

160-
| Name | Description | Value |
161-
| ------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------- |
162-
| `controllerManager.kubeRbacProxy.image.repository` | Sets the image for the kube-rbac-proxy. | `gcr.io/kubebuilder/kube-rbac-proxy` |
163-
| `controllerManager.kubeRbacProxy.image.tag` | Sets the version tag for the kube-rbac-proxy. | `v0.14.1` |
164-
| `controllerManager.kubeRbacProxy.resources.limits.cpu` | Sets cpu resource limits for kube-rbac-proxy. | `500m` |
165-
| `controllerManager.kubeRbacProxy.resources.limits.memory` | Sets memory resource limits for kube-rbac-proxy. | `128Mi` |
166-
| `controllerManager.kubeRbacProxy.resources.requests.cpu` | Sets cpu resource requests for kube-rbac-proxy. | `5m` |
167-
| `controllerManager.kubeRbacProxy.resources.requests.memory` | Sets memory resource requests for kube-rbac-proxy. | `64Mi` |
168-
| `controllerManager.manager.image.repository` | Sets the image for the operator. | `ghcr.io/open-feature/open-feature-operator` |
169-
| `controllerManager.manager.image.tag` | Sets the version tag for the operator. | `v0.5.6` |
170-
| `controllerManager.manager.resources.limits.cpu` | Sets cpu resource limits for operator. | `500m` |
171-
| `controllerManager.manager.resources.limits.memory` | Sets memory resource limits for operator. | `128Mi` |
172-
| `controllerManager.manager.resources.requests.cpu` | Sets cpu resource requests for operator. | `10m` |
173-
| `controllerManager.manager.resources.requests.memory` | Sets memory resource requests for operator. | `64Mi` |
174-
| `controllerManager.replicas` | Sets number of replicas of the OpenFeature operator pod. | `1` |
175-
| `managerConfig.flagsValidatonEnabled` | Enables the validating webhook for FeatureFlag CR. | `true` |
176-
| `managerConfig.flagdResourceEnabled` | Enables the controller for the Flagd CR and adds the required permissions to automatically manage the exposure of flagd via Service and Ingress resources. | `true` |
177-
| `managerConfig.controllerManagerConfigYaml.health.healthProbeBindAddress` | Sets the bind address for health probes. | `:8081` |
178-
| `managerConfig.controllerManagerConfigYaml.metrics.bindAddress` | Sets the bind address for metrics. | `127.0.0.1:8080` |
179-
| `managerConfig.controllerManagerConfigYaml.webhook.port` | Sets the bind address for webhook. | `9443` |
160+
| Name | Description | Value |
161+
| ------------------------------------------------------------------------- | -------------------------------------------------------- | -------------------------------------------- |
162+
| `controllerManager.kubeRbacProxy.image.repository` | Sets the image for the kube-rbac-proxy. | `gcr.io/kubebuilder/kube-rbac-proxy` |
163+
| `controllerManager.kubeRbacProxy.image.tag` | Sets the version tag for the kube-rbac-proxy. | `v0.14.1` |
164+
| `controllerManager.kubeRbacProxy.resources.limits.cpu` | Sets cpu resource limits for kube-rbac-proxy. | `500m` |
165+
| `controllerManager.kubeRbacProxy.resources.limits.memory` | Sets memory resource limits for kube-rbac-proxy. | `128Mi` |
166+
| `controllerManager.kubeRbacProxy.resources.requests.cpu` | Sets cpu resource requests for kube-rbac-proxy. | `5m` |
167+
| `controllerManager.kubeRbacProxy.resources.requests.memory` | Sets memory resource requests for kube-rbac-proxy. | `64Mi` |
168+
| `controllerManager.manager.image.repository` | Sets the image for the operator. | `ghcr.io/open-feature/open-feature-operator` |
169+
| `controllerManager.manager.image.tag` | Sets the version tag for the operator. | `v0.5.7` |
170+
| `controllerManager.manager.resources.limits.cpu` | Sets cpu resource limits for operator. | `500m` |
171+
| `controllerManager.manager.resources.limits.memory` | Sets memory resource limits for operator. | `128Mi` |
172+
| `controllerManager.manager.resources.requests.cpu` | Sets cpu resource requests for operator. | `10m` |
173+
| `controllerManager.manager.resources.requests.memory` | Sets memory resource requests for operator. | `64Mi` |
174+
| `controllerManager.replicas` | Sets number of replicas of the OpenFeature operator pod. | `1` |
175+
| `managerConfig.flagsValidatonEnabled` | Enables the validating webhook for FeatureFlag CR. | `true` |
176+
| `managerConfig.controllerManagerConfigYaml.health.healthProbeBindAddress` | Sets the bind address for health probes. | `:8081` |
177+
| `managerConfig.controllerManagerConfigYaml.metrics.bindAddress` | Sets the bind address for metrics. | `127.0.0.1:8080` |
178+
| `managerConfig.controllerManagerConfigYaml.webhook.port` | Sets the bind address for webhook. | `9443` |

‎chart/open-feature-operator/templates/rbac.authorization.k8s.io_v1_clusterrole_open-feature-operator-manager-role.yaml‎

Lines changed: 0 additions & 139 deletions
This file was deleted.

‎chart/open-feature-operator/templates/rbac.authorization.k8s.io_v1_clusterrolebinding_open-feature-operator-manager-rolebinding.yaml‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎chart/open-feature-operator/values.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ controllerManager:
141141
managerConfig:
142142
## @param managerConfig.flagsValidatonEnabled Enables the validating webhook for FeatureFlag CR.
143143
flagsValidatonEnabled: "true"
144-
## @param managerConfig.flagdResourceEnabled Enables the controller for the Flagd CR and adds the required permissions to automatically manage the exposure of flagd via Service and Ingress resources.
145-
flagdResourceEnabled: "true"
146144
controllerManagerConfigYaml:
147145
health:
148146
## @param managerConfig.controllerManagerConfigYaml.health.healthProbeBindAddress Sets the bind address for health probes.

‎common/types/envconfig.go‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ type EnvConfig struct {
3131
SidecarSyncProvider string `envconfig:"SIDECAR_SYNC_PROVIDER" default:"kubernetes"`
3232
SidecarLogFormat string `envconfig:"SIDECAR_LOG_FORMAT" default:"json"`
3333
SidecarProbesEnabled bool `envconfig:"SIDECAR_PROBES_ENABLED" default:"true"`
34-
FlagdResourceEnabled bool `envconfig:"FLAGD_RESOURCE_ENABLED" default:"true"`
3534
// in-process configuration
3635
InProcessPort int `envconfig:"IN_PROCESS_PORT" default:"8015"`
3736
InProcessSocketPath string `envconfig:"IN_PROCESS_SOCKET_PATH" default:""`

‎config/overlays/helm/exclude-role.yaml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎config/overlays/helm/exclude-rolebinding.yaml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎config/overlays/helm/kustomization.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ patchesStrategicMerge:
1515
- exclude-ns.yaml
1616
- manager.yaml
1717
- exclude-validatingwebhook.yaml
18-
- exclude-role.yaml
19-
- exclude-rolebinding.yaml
2018

2119
configMapGenerator:
2220
- name: manager-config

‎config/overlays/helm/manager.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ spec:
6666
value: "{{ .Values.flagdConfiguration.debugLogging }}"
6767
- name: FLAGS_VALIDATION_ENABLED
6868
value: "{{ .Values.managerConfig.flagsValidatonEnabled }}"
69-
- name: FLAGD_RESOURCE_ENABLED
70-
value: "{{ .Values.managerConfig.flagdResourceEnabled }}"
7169
- name: IN_PROCESS_PORT
7270
value: "{{ .Values.inProcessConfiguration.port }}"
7371
- name: IN_PROCESS_HOST

0 commit comments

Comments
 (0)