fix: Ingress annotations not reconciling (#773)

Signed-off-by: Yosiah de Koeyer <[email protected]>

Author: Y0sh1dk

internal/controller/core/flagd/resources/ingress.go

@@ -6,7 +6,7 @@ import (
 
 	api "github.com/open-feature/open-feature-operator/apis/core/v1beta1"
 	"github.com/open-feature/open-feature-operator/internal/common"
-	"github.com/open-feature/open-feature-operator/internal/controller/core/flagd/common"
+	resources "github.com/open-feature/open-feature-operator/internal/controller/core/flagd/common"
 	networkingv1 "k8s.io/api/networking/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -27,7 +27,7 @@ func (r FlagdIngress) AreObjectsEqual(o1 client.Object, o2 client.Object) bool {
 		return false
 	}
 
-	return reflect.DeepEqual(oldIngress.Spec, newIngress.Spec)
+	return reflect.DeepEqual(oldIngress.Spec, newIngress.Spec) && reflect.DeepEqual(oldIngress.Annotations, newIngress.Annotations)
 }
 
 func (r FlagdIngress) GetResource(_ context.Context, flagd *api.Flagd) (client.Object, error) {

internal/controller/core/flagd/resources/ingress_test.go

@@ -164,7 +164,6 @@ func TestFlagdIngress_getIngress(t *testing.T) {
 			},
 		},
 	}, ingressResult.(*networkingv1.Ingress).Spec)
-
 }
 
 func strPtr(s string) *string {
@@ -182,7 +181,7 @@ func Test_areIngressesEqual(t *testing.T) {
 		want bool
 	}{
 		{
-			name: "has changed",
+			name: "has spec changes",
 			args: args{
 				old: &networkingv1.Ingress{
 					Spec: networkingv1.IngressSpec{
@@ -197,6 +196,27 @@ func Test_areIngressesEqual(t *testing.T) {
 			},
 			want: false,
 		},
+		{
+			name: "has annotation changes",
+			args: args{
+				old: &networkingv1.Ingress{
+					ObjectMeta: metav1.ObjectMeta{
+						Annotations: map[string]string{
+							"foo": "bar",
+						},
+					},
+					Spec: networkingv1.IngressSpec{
+						IngressClassName: strPtr("nginx"),
+					},
+				},
+				new: &networkingv1.Ingress{
+					Spec: networkingv1.IngressSpec{
+						IngressClassName: strPtr("nginx"),
+					},
+				},
+			},
+			want: false,
+		},
 		{
 			name: "has not changed",
 			args: args{
@@ -240,7 +260,6 @@ func Test_areIngressesEqual(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-
 			i := &FlagdIngress{}
 			got := i.AreObjectsEqual(tt.args.old, tt.args.new)